linux-kernel - Re: [PATCH] mfd: simple-mfd-i2c: remove select I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <579629FC3E61E9E6+aPhgN9kIRsEhuGE1@kernel.org>
Date: Wed, 22 Oct 2025 12:40:23 +0800
From: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
To: Alex Elder <elder@...cstar.com>,
	Troy Mitchell <troy.mitchell@...ux.spacemit.com>,
	Lee Jones <lee@...nel.org>, Yixun Lan <dlan@...too.org>
Cc: linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
	spacemit@...ts.linux.dev, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] mfd: simple-mfd-i2c: remove select I2C_K1

On Wed, Oct 22, 2025 at 12:37:53PM +0800, Troy Mitchell wrote:
> On Tue, Oct 21, 2025 at 11:30:37PM -0500, Alex Elder wrote:
> > On 10/21/25 8:58 PM, Troy Mitchell wrote:
> > > select will force a symbol to a specific value without considering
> > > its dependencies. As a result, the i2c-k1 driver will fail to build
> > > when OF or COMMON_CLK are disabled.
> > 
> > Should config I2C_K1 depend on COMMON_CLK then?
> Yes, this patch [1] registers the ILCR as a clock.
> 
> > 
> > But you're right, the selecting config should ensure the
> > dependencies of the selected one are satisfied.
> And the config REGULATOR_SPACEMIT_P1 select MFD_SPACEMIT_P1(RTC same).
> Should we change it to depends on?
Yixun has suggessted here[1] and I think too.

Link: https://lore.kernel.org/all/20251022004830-GYB1522542@gentoo.org/ [1]