linux-kernel - Re: [PATCH v3 09/22] smb: move copychunk definitions to common/smb2pdu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35ae5b68-f271-43c9-8641-359fcf60e2e7@linux.dev>
Date: Wed, 22 Oct 2025 13:47:18 +0800
From: ChenXiaoSong <chenxiaosong.chenxiaosong@...ux.dev>
To: Namjae Jeon <linkinjeon@...nel.org>
Cc: stfrench@...rosoft.com, metze@...ba.org, pali@...nel.org,
 smfrench@...il.com, sfrench@...ba.org, senozhatsky@...omium.org,
 tom@...pey.com, pc@...guebit.org, ronniesahlberg@...il.com,
 sprasad@...rosoft.com, bharathsm@...rosoft.com,
 christophe.jaillet@...adoo.fr, zhangguodong@...inos.cn,
 linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
 ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: Re: [PATCH v3 09/22] smb: move copychunk definitions to
 common/smb2pdu.h

Hi Namjae,

In this patch, COPY_CHUNK_RES_KEY_SIZE has already been moved to 
common/smb2pdu.h

-- 
Thanks,
ChenXiaoSong.

On 10/20/25 1:03 PM, Namjae Jeon wrote:
>> diff --git a/fs/smb/client/smb2pdu.h b/fs/smb/client/smb2pdu.h
>> index 0be63c00f848..9b5880e60a4e 100644
>> --- a/fs/smb/client/smb2pdu.h
>> +++ b/fs/smb/client/smb2pdu.h
>> @@ -191,36 +191,12 @@ struct crt_sd_ctxt {
>>          struct smb3_sd sd;
>>   } __packed;
>>
>> -
>> -#define COPY_CHUNK_RES_KEY_SIZE        24
>>   struct resume_key_req {
>>          char ResumeKey[COPY_CHUNK_RES_KEY_SIZE];
>>          __le32  ContextLength;  /* MBZ */
>>          char    Context[];      /* ignored, Windows sets to 4 bytes of zero */
>>   } __packed;
> This can also be moved along with copychunk structures.
> Thanks.