linux-kernel - Re: [PATCH] rust: fix tests under Rust 1.89.0's `CStr` `Debug` impl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72mM-scMGCFxogHXP=4Omr23uVEg4cBBsZARhSCt+9kHuQ@mail.gmail.com>
Date: Wed, 22 Oct 2025 07:51:27 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Tamir Duberstein <tamird@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Tamir Duberstein <tamird@...il.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] rust: fix tests under Rust 1.89.0's `CStr` `Debug` impl

On Mon, Oct 20, 2025 at 5:27 PM Tamir Duberstein <tamird@...nel.org> wrote:
>
> Starting with Rust 1.89.0, `<CStr as Debug>::fmt` prints UTF-8 sequences
> unescaped.
>
> Thus update our test to expect the new behavior starting with Rust
> 1.89.0.
>
> Fixes: a1ec674cd709 ("rust: replace `CStr` with `core::ffi::CStr`")
> Link: https://github.com/rust-lang/rust/commit/a82062055af1ecdcb7f4d3371855aae843fc0ae3
> Signed-off-by: Tamir Duberstein <tamird@...nel.org>
> ---
> Hi Miguel, please feel free to rebase this in, if easier.

Thanks Tamir, yeah, I saw the test failing in my CI.

To keep things simple, I just removed that assert for the moment -- if
we care about the escaping behavior on debug formatting to the point
of testing the behavior on different Rust versions, then we can
re-introduce it.

    [ Removed assert that would now depend on the Rust version. - Miguel ]

I took the chance to take the tags we got so far too.

I appreciate that you took the time to put the link to the relevant
commit upstream (in this case, it was yourself, but still :)

Cheers,
Miguel