linux-kernel - Re: [PATCH] rust: acpi: replace `core::mem::zeroed` with `pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <edef2e95-d270-41cf-9ba5-390688fe2c15@linux.dev>
Date: Wed, 22 Oct 2025 14:02:19 +0800
From: Kunwu Chan <kunwu.chan@...ux.dev>
To: Siyuan Huang <huangsiyuan@...inos.cn>, rafael@...nel.org,
 lenb@...nel.org, ojeda@...nel.org, alex.gaynor@...il.com,
 boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com,
 lossin@...nel.org, a.hindborg@...nel.org, aliceryhl@...gle.com,
 tmgross@...ch.edu, dakr@...nel.org
Cc: linux-acpi@...r.kernel.org, rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: acpi: replace `core::mem::zeroed` with
 `pin_init::zeroed`

On 10/20/25 11:12, Siyuan Huang wrote:
> All types in `bindings` implement `Zeroable` if they can, so use
> `pin_init::zeroed` instead of relying on `unsafe` code.
>
> If this ends up not compiling in the future, something in bindgen or on
> the C side changed and is most likely incorrect.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1189
> Suggested-by: Benno Lossin <lossin@...nel.org>
> Signed-off-by: Siyuan Huang <huangsiyuan@...inos.cn>
> ---
>   rust/kernel/acpi.rs | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/rust/kernel/acpi.rs b/rust/kernel/acpi.rs
> index 7ae317368b00..f9488be9249c 100644
> --- a/rust/kernel/acpi.rs
> +++ b/rust/kernel/acpi.rs
> @@ -42,9 +42,7 @@ pub const fn new(id: &'static CStr) -> Self {
>               "ID exceeds 16 bytes"
>           );
>           let src = id.as_bytes_with_nul();
> -        // Replace with `bindings::acpi_device_id::default()` once stabilized for `const`.
> -        // SAFETY: FFI type is valid to be zero-initialized.
> -        let mut acpi: bindings::acpi_device_id = unsafe { core::mem::zeroed() };
> +        let mut acpi: bindings::acpi_device_id = pin_init::zeroed();
>           let mut i = 0;
>           while i < src.len() {
>               acpi.id[i] = src[i];


Reviewed-by: Kunwu Chan <chentao@...inos.cn>

-- 
Thanks,
        Kunwu Chan.