linux-kernel - Re: [PATCH 2/2] nvme-pci: Add debug message on fail to read CSTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee6739203c5dbd7452541a3915636b597b34848f.camel@gmail.com>
Date: Wed, 22 Oct 2025 16:24:45 +1000
From: Wilfred Mallawa <wilfred.opensource@...il.com>
To: Gerd Bayer <gbayer@...ux.ibm.com>, Keith Busch <kbusch@...nel.org>, Jens
 Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>, Sagi Grimberg
 <sagi@...mberg.me>
Cc: Niklas Schnelle <schnelle@...ux.ibm.com>,
 linux-nvme@...ts.infradead.org, 	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] nvme-pci: Add debug message on fail to read CSTS

On Mon, 2025-10-20 at 17:29 +0200, Gerd Bayer wrote:
> Add a debug log spelling out that reading the CSTS register failed -
> to
> distinguish this from other reasons for ENODEV.
> 
> Signed-off-by: Gerd Bayer <gbayer@...ux.ibm.com>
> ---
>  drivers/nvme/host/pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index
> 7544c4bac2c4a230d32cf729abb9e94bf93a921f..c3b0a9d56ac1f32f67ce0890bec
> d6425eb80ebad 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2906,6 +2906,7 @@ static int nvme_pci_enable(struct nvme_dev
> *dev)
>  	pci_set_master(pdev);
>  
>  	if (readl(dev->bar + NVME_REG_CSTS) == -1) {
> +		dev_dbg(dev->ctrl.device, "Read CSTS register
> failed");
>  		result = -ENODEV;
>  		goto disable;
>  	}
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@....com>

Wilfred