linux-kernel - Re: [PATCH v3 02/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d9c4fe2-72c2-45b2-ad15-8cf5f825e53c@kernel.org>
Date: Wed, 22 Oct 2025 08:36:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: André Draszik <andre.draszik@...aro.org>
Cc: Alim Akhtar <alim.akhtar@...sung.com>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
 Marek Szyprowski <m.szyprowski@...sung.com>,
 Peter Griffin <peter.griffin@...aro.org>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 02/10] dt-bindings: soc: samsung: exynos-pmu: move
 gs101-pmu into separate binding

On 22/10/2025 08:34, Krzysztof Kozlowski wrote:
> On Thu, Oct 16, 2025 at 04:58:35PM +0100, André Draszik wrote:
>> The gs101-pmu binding is going to acquire various additional (pattern)
>> properties that don't apply to other PMUs supported by this binding.
>>
>> To enable this, move google,gs101-pmu into a separate binding.
> 
> You did not copy all the properties which effectively drops certain
> things from the binding, e.g. clocks, interrupt-controller and maybe
> more. Please list them in commit msg and explain they are not applicable
> to GS101.
> 
>>
>> Signed-off-by: André Draszik <andre.draszik@...aro.org>
>>
>> ---
>> v3:
>> - use additionalProperties, not unevaluatedProperties
>> - fix path in $id (Rob)
>> - drop comment around 'select' (Rob)


Ah, and please make the example complete by adding
syscon-reboot/poweroff nodes.

Best regards,
Krzysztof