linux-kernel - Re: [PATCH 5/5] Documentation/devicetree/bindings/hwmon: Add TSC1641 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e396d81b-0f61-4a05-873e-354339b5e50e@kernel.org>
Date: Wed, 22 Oct 2025 08:48:43 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Igor Reznichenko <igor@...nichenko.net>, linux@...ck-us.net,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, corbet@....net,
 skhan@...uxfoundation.org, david.hunter.linux@...il.com
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH 5/5] Documentation/devicetree/bindings/hwmon: Add TSC1641
 binding

On 22/10/2025 06:47, Igor Reznichenko wrote:
> Add a devicetree binding for the TSC1641 I2C power monitor.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Please organize the patch documenting compatible (DT bindings) before
their user.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46

> 
> Signed-off-by: Igor Reznichenko <igor@...nichenko.net>
> ---
>  .../devicetree/bindings/hwmon/st,tsc1641.yaml | 54 +++++++++++++++++++
>  1 file changed, 54 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/st,tsc1641.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/st,tsc1641.yaml b/Documentation/devicetree/bindings/hwmon/st,tsc1641.yaml
> new file mode 100644
> index 000000000000..e79f6dab4a87
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/st,tsc1641.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/st,tsc1641.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ST Microelectronics TSC1641 I2C power monitor
> +
> +maintainers:
> +  - Igor Reznichenko <igor@...nichenko.net>
> +
> +description: |
> +  TSC1641 is a 60 V, 16-bit high-precision power monitor with I2C and MIPI I3C interface

Please wrap code according to the preferred limit expressed in Kernel
coding style, so at 80.

> +
> +  Datasheets:
> +    https://www.st.com/resource/en/datasheet/tsc1641.pdf
> +
> +properties:
> +  compatible:
> +    const: st,tsc1641
> +
> +  reg:
> +    maxItems: 1
> +
> +  shunt-resistor:

Use existing property, git grep shunt.

And then test it...

Best regards,
Krzysztof