linux-kernel - Re: [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2021d28-63d9-415c-89d8-2beac80aab94@suse.de>
Date: Wed, 22 Oct 2025 10:19:13 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Marcus Folkesson <marcus.folkesson@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] drm/sitronix/st7571-i2c: remove unneeded semicolon

Hi

Am 22.10.25 um 09:59 schrieb Marcus Folkesson:
> On Wed, Oct 22, 2025 at 08:10:57AM +0200, Marcus Folkesson wrote:
>> Fix style issue reported by Kernel test robot.
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202510221125.Cg0sM4xJ-lkp@intel.com/
>> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
>> ---
>>   drivers/gpu/drm/sitronix/st7571-i2c.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
>> index 32b91d65b768b26caa7dcef42a00d36f236fbc32..4e73c8b415d677dab5b421666b56f4bb3697b982 100644
>> --- a/drivers/gpu/drm/sitronix/st7571-i2c.c
>> +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
>> @@ -322,7 +322,7 @@ static void st7571_prepare_buffer_grayscale(struct st7571_device *st7571,
>>   		size = (rect->x2 - rect->x1) * (rect->y2 - rect->y1) / 4;
>>   		memcpy(st7571->hwbuf, vmap->vaddr, size);
>>   		break;
>> -	};
>> +	}
>>   }
>>   
>>   static int st7571_fb_update_rect_monochrome(struct drm_framebuffer *fb, struct drm_rect *rect)
>>
>> ---
>> base-commit: c1a7cc00cd412505e070eb4e62bc0b0ca85243e0
>> change-id: 20251022-st7571-semicolon-bc5287cde264
>>
>> Best regards,
>> -- 
>> Marcus Folkesson <marcus.folkesson@...il.com>
>>
> Pushed to drm-misc-fixes.

This does not belong into -fixes as it's not a bug fix, just a style 
issue. Also misses the Fixes tag. No need to revert, but please keep in 
mind for next time.

Best regards
Thomas

>
> Best regards,
> Marcus Folkesson

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)