linux-kernel - Re: [PATCH v2 4/4] regulators: qcom-rpmh-regulator: Fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <pldvmkjm7muflwti25rc24so3jbkxgyg3uhk2btuzpimjv5emc@62wz5dyksjr4>
Date: Wed, 22 Oct 2025 11:44:53 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Kamal Wadhwa <kamal.wadhwa@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] regulators: qcom-rpmh-regulator: Fix coding style
 issues

On Wed, Oct 22, 2025 at 02:38:56AM +0530, Kamal Wadhwa wrote:
> Fix the code style/format issues reported by checkpatch.pl
> script.
> 
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@....qualcomm.com>
> ---
>  drivers/regulator/qcom-rpmh-regulator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Why are you fixing a patch that was a part of this series?

> 
> diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> index 9f693043cb87aa77a7a529b5b973323450db80be..6a36ef967d5d9e32c005e79a12099ebef824842f 100644
> --- a/drivers/regulator/qcom-rpmh-regulator.c
> +++ b/drivers/regulator/qcom-rpmh-regulator.c
> @@ -109,7 +109,7 @@ static const struct resource_name_formats vreg_rsc_name_lookup[NUM_REGULATOR_TYP
>   *				regulator
>   * @ops:			Pointer to regulator ops callback structure
>   * @voltage_ranges:		The possible ranges of voltages supported by this
> - * 				PMIC regulator type
> + *				PMIC regulator type
>   * @n_linear_ranges:		Number of entries in voltage_ranges
>   * @n_voltages:			The number of unique voltage set points defined
>   *				by voltage_ranges
> @@ -387,7 +387,7 @@ static int rpmh_regulator_vrm_set_mode_bypass(struct rpmh_vreg *vreg,
>  		return pmic_mode;
>  
>  	if (bypassed) {
> -		if(!vreg->hw_data->bypass_supported)
> +		if (!vreg->hw_data->bypass_supported)
>  			return -EINVAL;
>  		cmd.data = vreg->hw_data->pmic_bypass_mode;
>  	} else {
> 
> -- 
> 2.25.1
> 

-- 
With best wishes
Dmitry