linux-kernel - Re: [PATCH 16/15] bugs/s390: Use in 'cond_str' to __EMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251022085221.14219A7f-hca@linux.ibm.com>
Date: Wed, 22 Oct 2025 10:52:21 +0200
From: Heiko Carstens <hca@...ux.ibm.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>, linux-arch@...r.kernel.org,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, linux-s390@...r.kernel.org
Subject: Re: [PATCH 16/15] bugs/s390: Use in 'cond_str' to __EMIT_BUG()

Hi Ingo,

On Mon, Jun 09, 2025 at 05:56:57PM +0200, Heiko Carstens wrote:
> On Mon, Jun 09, 2025 at 10:27:44AM +0200, Ingo Molnar wrote:
> > So I'm not sure what happened: I tried to reproduce what I did 
> > originally, but my naive patch ran into assembler build errors when a 
> > WARN_ON() macro tried to use the '%' C operator, such as 
> > fs/crypto/crypto.c:123:
> > 
> >  include/linux/compiler_types.h:497:20: error: invalid 'asm': invalid %-code
> >  arch/s390/include/asm/bug.h:12:2: note: in expansion of macro 'asm_inline'
> >  arch/s390/include/asm/bug.h:50:2: note: in expansion of macro '__EMIT_BUG'
> >  include/asm-generic/bug.h:119:3: note: in expansion of macro '__WARN_FLAGS'
> >  fs/crypto/crypto.c:123:6: note: in expansion of macro 'WARN_ON_ONCE'
> > 
> > Which corresponds to:
> > 
> >         if (WARN_ON_ONCE(len % FSCRYPT_CONTENTS_ALIGNMENT != 0))
> >                 return -EINVAL;
> > 
> > I'm quite sure I never saw these build errors - I saw linker errors 
> > related to the u16 overflow I documented in the changelog. (Note to 
> > self: copy & paste more of the build error context next time around.)
> > 
> > Your version doesn't have that build problem, so I picked it up with 
> > the changelog below and your Signed-off-by. Does that look good to you?
> 
> Yes, fine with me.

Given that this missed the last merge I'm wondering what is supposed to
happen with this series?

It is still in linux-next, and I'd like to see at least the non
CONFIG_DEBUG_BUGVERBOSE_DETAILED s390 parts upstream with the next merge
window. In particular I'm talking about the two commits

ed845c363d8c ("bugs/s390: Remove private WARN_ON() implementation")
6584ff203aec ("bugs/s390: Use 'cond_str' in __EMIT_BUG()")

where the second commit is mainly a rework of the s390 specific bug
support.