linux-kernel - Re: [PATCH] dmaengine: sh: rz_dmac: remove braces around single statement if block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXqXGPfQNB3SUQkcsHkaWhxjfN2KG0CNeYdoKwNAT7dYQ@mail.gmail.com>
Date: Wed, 22 Oct 2025 11:19:57 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>
Cc: Vinod Koul <vkoul@...nel.org>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, dmaengine@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: sh: rz_dmac: remove braces around single
 statement if block

Hi Cosmin,

On Wed, 22 Oct 2025 at 09:39, Cosmin Tanislav
<cosmin-gabriel.tanislav.xa@...esas.com> wrote:
> Braces around single statement if blocks are unnecessary, remove them.
>
> Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

> --- a/drivers/dma/sh/rz-dmac.c
> +++ b/drivers/dma/sh/rz-dmac.c
> @@ -336,13 +336,12 @@ static void rz_dmac_prepare_desc_for_memcpy(struct rz_dmac_chan *channel)
>         lmdesc->chext = 0;
>         lmdesc->header = HEADER_LV;
>
> -       if (dmac->has_icu) {
> +       if (dmac->has_icu)
>                 rzv2h_icu_register_dma_req(dmac->icu.pdev, dmac->icu.dmac_index,
>                                            channel->index,
>                                            RZV2H_ICU_DMAC_REQ_NO_DEFAULT);
> -       } else {
> +       else
>                 rz_dmac_set_dmars_register(dmac, channel->index, 0);
> -       }

Seeing this same construct being repeated three times, I think it
would be good to introduce a helper (in a separate patch, of course).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds