linux-kernel - Re: [PATCH v2] driver core: Check drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025102252-nearest-hangover-5346@gregkh>
Date: Wed, 22 Oct 2025 12:32:00 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Vincent Liu <vincent.liu@...anix.com>
Cc: "dakr@...nel.org" <dakr@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rafael@...nel.org" <rafael@...nel.org>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH v2] driver core: Check drivers_autoprobe for all added
 devices

On Tue, Oct 21, 2025 at 12:49:21PM +0000, Vincent Liu wrote:
> > On 14 Oct 2025, at 13:10, Vincent Liu <vincent.liu@...anix.com> wrote:
> > 
> > On 14 Oct 2025, at 06:14, Greg KH <gregkh@...uxfoundation.org> wrote:
> > 
> >> What commit id does this fix?
> > 
> > I am not entirely sure if there is a particular commit that causes this issue,
> > the device_attach call was added in pci/bus.c 58d9a38f6fac, and then the
> > device_add was removed in 4f535093cf8f6. At this point I think the
> > drivers_autoprobe stopped working because driver_attach that’s left in
> > pci_bus_add_device does not check for that.
> > 
> > The drivers_autoprobe check in base/bus.c has been there a long time 
> > since b8c5cec23d5c.
> > 
> >> What devices cause this to happen today that are seeing this issue?
> > 
> > I am observing this for hot-plugged PCIe devices and VFs.
> > 
> >> Should this be backported to older kernels?
> > 
> > I suppose not since this was not working for a long time?
> > 
> 
> Are you happy with this reply Greg? Do you want me to update the commit
> message to include some of these commit ids?

Please do.