linux-kernel - Re: [PATCH v2] Signed-off-by: Biancaa Ramesh …

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1461717-1a58-46f7-b8fd-a185aaf90828@web.de>
Date: Wed, 22 Oct 2025 13:14:24 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Biancaa Ramesh <biancaa2210329@....edu.in>, linux-media@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, Sumit Semwal <sumit.semwal@...aro.org>
Cc: linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org,
 lkp@...el.com, Christian König <christian.koenig@....com>
Subject: Re: [PATCH v2] Signed-off-by: Biancaa Ramesh …

> dma-buf: improve dma_buf_show_fdinfo output
…
> This patch also fixes incorrect …

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc2#n94

> Closes: https://lore.kernel.org/oe-kbuild-all/202510220802.svbgdYsJ-lkp@intel.com/

Not yet.

Please use a more appropriate patch subject for the proposed adjustment
of the function “dma_buf_show_fdinfo”.
https://elixir.bootlin.com/linux/v6.18-rc2/source/drivers/dma-buf/dma-buf.c#L570-L582
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc2#n396

> ---
>  drivers/dma-buf/dma-buf.c | 26 ++++++++++++--------------
…

Some contributors would appreciate patch version descriptions.
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc2#n310

…
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -571,24 +571,22 @@ static long dma_buf_ioctl(struct file *file,
>  	}
>  }
>  
> -static void dma_buf_show_fdinfo(struct seq_file *s, struct file *f)
> +static void dma_buf_show_fdinfo(struct seq_file *s, struct file *file)
>  {
…
…
> -    seq_printf(s, "flags:\t%lu\n", f->f_flags);
> -    seq_printf(s, "size:\t%llu\n", dmabuf->size);

* Why does such a diff representation contain space characters instead of tab characters?

* Did you refer to a source code variant before the commit bcc071110aeacd28a87525a2442dd96eab145a3c
  ("dma-buf: add show_fdinfo handler") from 2019-06-14?

…
> -- 
> ::DISCLAIMER::
…
> The 
> contents of this e-mail and any attachment(s) are confidential and
…

Please avoid such unwanted information for communication by the means of public mailing lists.
https://subspace.kernel.org/etiquette.html#do-not-include-confidentiality-disclaimers

Regards,
Markus