linux-kernel - Re: [PATCH] Input: atkbd - skip deactivate for HONOR FMB-P's internal keyboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dde1e6eb-34e2-4d71-99b3-c5d8fad4940c@kernel.org>
Date: Wed, 22 Oct 2025 13:20:01 +0200
From: Hans de Goede <hansg@...nel.org>
To: Cryolitia PukNgae <cryolitia.pukngae@...ux.dev>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...nel.org, zhanjun@...ontech.com, niecheng1@...ontech.com,
 cryolitia@...ontech.com, Mingcong Bai <jeffbai@...c.io>,
 Kexy Biscuit <kexybiscuit@...c.io>, Mikura Kyouka <mikurakyouka@...c.io>,
 "foad.elkhattabi" <foad.elkhattabi@...il.com>
Subject: Re: [PATCH] Input: atkbd - skip deactivate for HONOR FMB-P's internal
 keyboard

Hi,

On 22-Oct-25 12:40 PM, Cryolitia PukNgae wrote:
> After commit 9cf6e24c9fbf17e52de9fff07f12be7565ea6d61 ("Input: atkbd -
> do not skip atkbd_deactivate() when skipping ATKBD_CMD_GETID"), HONOR
> FMB-P, aka HONOR MagicBook Pro 14 2025's internal keyboard stops
> working. Adding the atkbd_deactivate_fixup quirk fixes it.
> 
> DMI: HONOR FMB-P/FMB-P-PCB, BIOS 1.13 05/08/2025
> 
> Fixes: 9cf6e24c9fbf17e52de9fff07f12be7565ea6d61 ("Input: atkbd - do not skip atkbd_deactivate() when skipping ATKBD_CMD_GETID")
> Reported-by: Mikura Kyouka <mikurakyouka@...c.io>
> Link: https://www.xiaohongshu.com/explore/68738d0a0000000012015a79
> Link: https://club.honor.com/cn/thread-29463529-1-1.html
> Link: https://club.honor.com/cn/thread-29490444-1-1.html
> Reported-by: foad.elkhattabi <foad.elkhattabi@...il.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=220384
> Signed-off-by: Cryolitia PukNgae <cryolitia.pukngae@...ux.dev>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@...nel.org>

Regards,

Hans



> ---
>  drivers/input/keyboard/atkbd.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index 6c999d89ee4b..422e28ad1e8e 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1937,6 +1937,13 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = {
>  		},
>  		.callback = atkbd_deactivate_fixup,
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "HONOR"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "FMB-P"),
> +		},
> +		.callback = atkbd_deactivate_fixup,
> +	},
>  	{ }
>  };
>  
> 
> ---
> base-commit: 552c50713f273b494ac6c77052032a49bc9255e2
> change-id: 20251022-honor-8bc9bef8eba7
> 
> Best regards,