linux-kernel - Re: [PATCH v2 2/2] nvme-pci: Add debug message on fail to read CSTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96c1a4e2bcf93d85b6ff33a30a045ebe7b29fb46.camel@linux.ibm.com>
Date: Thu, 23 Oct 2025 16:17:31 +0200
From: Gerd Bayer <gbayer@...ux.ibm.com>
To: John Garry <john.g.garry@...cle.com>, Keith Busch <kbusch@...nel.org>,
        Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
        Sagi Grimberg
 <sagi@...mberg.me>
Cc: Niklas Schnelle <schnelle@...ux.ibm.com>,
        Greg Kroah-Hartman	
 <gregkh@...uxfoundation.org>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Wilfred
 Mallawa <wilfred.mallawa@....com>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Chaitanya Kulkarni	 <kch@...dia.com>
Subject: Re: [PATCH v2 2/2] nvme-pci: Add debug message on fail to read CSTS

On Thu, 2025-10-23 at 11:55 +0100, John Garry wrote:
> On 22/10/2025 11:33, Gerd Bayer wrote:
> > Add a debug log spelling out that reading the CSTS register failed - to
> > distinguish this from other reasons for ENODEV.
> > 
> > Reviewed-by: Wilfred Mallawa <wilfred.mallawa@....com>
> > Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>
> > Signed-off-by: Gerd Bayer <gbayer@...ux.ibm.com>
> > ---
> >   drivers/nvme/host/pci.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> > index 8c624960c9f67e0cc8409023de5e532d6ed9b3ac..ce563e93d29443a25e9236d0b6d8152ee85796d7 100644
> > --- a/drivers/nvme/host/pci.c
> > +++ b/drivers/nvme/host/pci.c
> > @@ -2906,6 +2906,7 @@ static int nvme_pci_enable(struct nvme_dev *dev)
> >   	pci_set_master(pdev);
> >   
> >   	if (readl(dev->bar + NVME_REG_CSTS) == -1) {
> > +		dev_dbg(dev->ctrl.device, "reading CSTS register failed");
> 
> we should add "\n" as a good practice, no?

that's a very valid point. Sheesh - how much can go wrong...

Thanks,
Gerd

> 
> >   		result = -ENODEV;
> >   		goto disable;
> >   	}
> >