linux-kernel - RE: [PATCH v5 6/6] clk: scmi: Add i.MX95 OEM extension support for SCMI clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8459BC290B855BFCA1C3D15E88F0A@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Thu, 23 Oct 2025 14:46:36 +0000
From: Peng Fan <peng.fan@....com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
CC: Michael Turquette <mturquette@...libre.com>, Stephen Boyd
	<sboyd@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Sudeep Holla
	<sudeep.holla@....com>, Cristian Marussi <cristian.marussi@....com>, Sebin
 Francis <sebin.francis@...com>, Brian Masney <bmasney@...hat.com>, Dan
 Carpenter <dan.carpenter@...aro.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-clk@...r.kernel.org"
	<linux-clk@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "arm-scmi@...r.kernel.org"
	<arm-scmi@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v5 6/6] clk: scmi: Add i.MX95 OEM extension support for
 SCMI clock driver

Hi Geert

Thanks for your feedback.

> Subject: Re: [PATCH v5 6/6] clk: scmi: Add i.MX95 OEM extension
> support for SCMI clock driver
> > +
> > +       /*
> > +        * extConfigValue[7:0]   - spread percentage (%)
> > +        * extConfigValue[23:8]  - Modulation Frequency
> 
> What is the unit of this?
> According to the code below, it is in Hz, so it is limited to 65535 Hz.

It is Hz, the modulation freq to i.MX95 is in range 30KHz - 64KHz.

> 
> > +        * extConfigValue[24]    - Enable/Disable
> > +        * extConfigValue[31:25] - Reserved
> 
> Center, up, down, could be stored here, I assume?

Our firmware does not provide modulation method
here. Here I just follow what our firmware defines.
Bit[31:25] is reserved in current firmware. It may
be extended to support modulation method, but I 
am not sure.

Thanks
Peng