linux-kernel - Re: [PATCH 1/2] NTB: ntb_transport: Remove unused 'retries' field from ntb_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f703de61-5616-40b8-b9b5-08529f711e64@intel.com>
Date: Thu, 23 Oct 2025 07:59:32 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Koichiro Den <den@...inux.co.jp>, ntb@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Cc: jdmason@...zu.us, allenbh@...il.com
Subject: Re: [PATCH 1/2] NTB: ntb_transport: Remove unused 'retries' field
 from ntb_queue_entry



On 10/23/25 12:21 AM, Koichiro Den wrote:
> Drop the unused field 'retries' from struct ntb_queue_entry for
> simplicity's sake.
> 
> Signed-off-by: Koichiro Den <den@...inux.co.jp>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>> ---
>  drivers/ntb/ntb_transport.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index eb875e3db2e3..39b2398b95a6 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -113,7 +113,6 @@ struct ntb_queue_entry {
>  	void *buf;
>  	unsigned int len;
>  	unsigned int flags;
> -	int retries;
>  	int errors;
>  	unsigned int tx_index;
>  	unsigned int rx_index;
> @@ -1630,9 +1629,7 @@ static void ntb_async_rx(struct ntb_queue_entry *entry, void *offset)
>  	if (res < 0)
>  		goto err;
>  
> -	if (!entry->retries)
> -		qp->rx_async++;
> -
> +	qp->rx_async++;
>  	return;
>  
>  err:
> @@ -1910,9 +1907,7 @@ static void ntb_async_tx(struct ntb_transport_qp *qp,
>  	if (res < 0)
>  		goto err;
>  
> -	if (!entry->retries)
> -		qp->tx_async++;
> -
> +	qp->tx_async++;
>  	return;
>  
>  err:
> @@ -2273,7 +2268,6 @@ int ntb_transport_rx_enqueue(struct ntb_transport_qp *qp, void *cb, void *data,
>  	entry->buf = data;
>  	entry->len = len;
>  	entry->flags = 0;
> -	entry->retries = 0;
>  	entry->errors = 0;
>  	entry->rx_index = 0;
>  
> @@ -2323,7 +2317,6 @@ int ntb_transport_tx_enqueue(struct ntb_transport_qp *qp, void *cb, void *data,
>  	entry->len = len;
>  	entry->flags = 0;
>  	entry->errors = 0;
> -	entry->retries = 0;
>  	entry->tx_index = 0;
>  
>  	rc = ntb_process_tx(qp, entry);