linux-kernel - Re: [PATCH v3 09/25] KVM: TDX: Fold tdx_sept_drop_private_spte() into tdx_sept_remove_private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPpC7mt3CwWuhv1p@google.com>
Date: Thu, 23 Oct 2025 07:59:58 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Kai Huang <kai.huang@...el.com>
Cc: "chenhuacai@...nel.org" <chenhuacai@...nel.org>, "frankja@...ux.ibm.com" <frankja@...ux.ibm.com>, 
	"maz@...nel.org" <maz@...nel.org>, "borntraeger@...ux.ibm.com" <borntraeger@...ux.ibm.com>, 
	"pjw@...nel.org" <pjw@...nel.org>, "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>, 
	"kas@...nel.org" <kas@...nel.org>, "maobibo@...ngson.cn" <maobibo@...ngson.cn>, 
	"pbonzini@...hat.com" <pbonzini@...hat.com>, "maddy@...ux.ibm.com" <maddy@...ux.ibm.com>, 
	"palmer@...belt.com" <palmer@...belt.com>, "imbrenda@...ux.ibm.com" <imbrenda@...ux.ibm.com>, 
	"zhaotianrui@...ngson.cn" <zhaotianrui@...ngson.cn>, "anup@...infault.org" <anup@...infault.org>, 
	"oliver.upton@...ux.dev" <oliver.upton@...ux.dev>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, 
	"linux-coco@...ts.linux.dev" <linux-coco@...ts.linux.dev>, Yan Y Zhao <yan.y.zhao@...el.com>, 
	"michael.roth@....com" <michael.roth@....com>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Ira Weiny <ira.weiny@...el.com>, 
	"loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>, 
	"binbin.wu@...ux.intel.com" <binbin.wu@...ux.intel.com>, 
	"ackerleytng@...gle.com" <ackerleytng@...gle.com>, "kvmarm@...ts.linux.dev" <kvmarm@...ts.linux.dev>, 
	"kvm-riscv@...ts.infradead.org" <kvm-riscv@...ts.infradead.org>, Vishal Annapurve <vannapurve@...gle.com>, 
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, 
	Rick P Edgecombe <rick.p.edgecombe@...el.com>, 
	"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>, 
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, 
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>, "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v3 09/25] KVM: TDX: Fold tdx_sept_drop_private_spte() into tdx_sept_remove_private_spte()

On Thu, Oct 23, 2025, Kai Huang wrote:
> On Thu, 2025-10-16 at 17:32 -0700, Sean Christopherson wrote:
> > Fold tdx_sept_drop_private_spte() into tdx_sept_remove_private_spte() to
> > avoid having to differnatiate between "zap", "drop", and "remove", and to
> 		  ^
> 		  differentiate
> 
> Nit: it's a wee bit confusing that you mentioned "zap", because after this
> patch tdx_sept_zap_private_spte() is still there.  But it may be only me
> feeling that way.

Hmm, yeah, I agree that's a confusing/misleading.  How about this?

  KVM: TDX: Fold tdx_sept_drop_private_spte() into tdx_sept_remove_private_spte()
  
  Fold tdx_sept_drop_private_spte() into tdx_sept_remove_private_spte() as a
  step towards having "remove" be the only and only function that deals with
  removing/zapping/dropping a SPTE, e.g. to avoid having to differentiate
  between "zap", "drop", and "remove".  Eliminating the "drop" helper also
  gets rid of what is effectively dead code due to redundant checks, e.g. on
  an HKID being assigned.
  
  No functional change intended.