linux-kernel - [PATCH] bus: fsl-mc: fix device reference leak in fsl_mc_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251023150558.890-1-vulab@iscas.ac.cn>
Date: Thu, 23 Oct 2025 23:05:58 +0800
From: Wentao Liang <vulab@...as.ac.cn>
To: ioana.ciornei@....com
Cc: linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org,
	Wentao Liang <vulab@...as.ac.cn>,
	stable@...r.kernel.org
Subject: [PATCH] bus: fsl-mc: fix device reference leak in fsl_mc_device_lookup()

The device_find_child() function calls the get_device() and returns a
device reference that must be properly released when no longer needed.
The fsl_mc_device_lookup() directly returns without releasing the
reference via put_device().

Add the missing put_device() call to prevent reference leaks.

Fixes: f2f2726b62f5 ("staging: fsl-mc: Device driver for FSL-MC DPRC devices")
Cc: stable@...r.kernel.org # v4.1+
Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
---
 drivers/bus/fsl-mc/dprc-driver.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/fsl-mc/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c
index c63a7e688db6..e92c75cef90c 100644
--- a/drivers/bus/fsl-mc/dprc-driver.c
+++ b/drivers/bus/fsl-mc/dprc-driver.c
@@ -124,11 +124,17 @@ struct fsl_mc_device *fsl_mc_device_lookup(struct fsl_mc_obj_desc *obj_desc,
 					   struct fsl_mc_device *mc_bus_dev)
 {
 	struct device *dev;
+	struct fsl_mc_device *mc_dev;
 
 	dev = device_find_child(&mc_bus_dev->dev, obj_desc,
 				__fsl_mc_device_match);
+	if (!dev)
+		return NULL;
+
+	mc_dev = to_fsl_mc_device(dev);
+	put_device(dev);
 
-	return dev ? to_fsl_mc_device(dev) : NULL;
+	return mc_dev;
 }
 
 /**
-- 
2.42.0.windows.2