linux-kernel - Re: [PATCH v3 3/3] printk: Use console_flush_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALqELGyLNdqzoz4xYnUE9XYb3bGY4iSejBotM=imMbx9LbLg_w@mail.gmail.com>
Date: Thu, 23 Oct 2025 16:21:53 +0100
From: Andrew Murray <amurray@...goodpenguin.co.uk>
To: Petr Mladek <pmladek@...e.com>
Cc: John Ogness <john.ogness@...utronix.de>, Steven Rostedt <rostedt@...dmis.org>, 
	Sergey Senozhatsky <senozhatsky@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] printk: Use console_flush_one_record for legacy
 printer kthread

On Thu, 23 Oct 2025 at 15:56, Petr Mladek <pmladek@...e.com> wrote:
>
> On Thu 2025-10-23 15:25:34, John Ogness wrote:
> > On 2025-10-20, Andrew Murray <amurray@...goodpenguin.co.uk> wrote:
> > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> > > index 6c846d2d37d9d20bad58c6e3a7caada3be9552ca..2665a7a59f03b3a357b3346de1735606e77c3496 100644
> > > --- a/kernel/printk/printk.c
> > > +++ b/kernel/printk/printk.c
> > > @@ -3644,17 +3644,26 @@ static bool legacy_kthread_should_wakeup(void)
> > >
> > >  static int legacy_kthread_func(void *unused)
> > >  {
> > > -   for (;;) {
> > > -           wait_event_interruptible(legacy_wait, legacy_kthread_should_wakeup());
> > > +   bool try_again;
> > > +
> > > +wait_for_event:
> > > +   wait_event_interruptible(legacy_wait, legacy_kthread_should_wakeup());
> > > +
> > > +   do {
> > > +           u64 next_seq = 0;
> > > +           bool handover = false;
> >
> > Nit: I prefer to sort by line length:
> >
> >               bool handover = false;
> >               u64 next_seq = 0;
>
> OK, no need to resend the patch. I'll change this when pushing it.

Sounds good to me.

Andrew Murray

>
> > With change:
> >
> > Reviewed-by: John Ogness <john.ogness@...utronix.de>
>
> The patch looks good to me as well:
>
> Reviewed-by: Petr Mladek <pmladek@...e.com>
>
> Best Regards,
> Petr