linux-kernel - Re: [PATCH v3 06/12] x86/amd_nb: Use topology info to get AMD node count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251023160906.GA730672@yaz-khff2.amd.com>
Date: Thu, 23 Oct 2025 12:09:06 -0400
From: Yazen Ghannam <yazen.ghannam@....com>
To: Michal Pecio <michal.pecio@...il.com>
Cc: Shyam-sundar.S-k@....com, bhelgaas@...gle.com, hdegoede@...hat.com,
	ilpo.jarvinen@...ux.intel.com, jdelvare@...e.com,
	linux-edac@...r.kernel.org, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	linux@...ck-us.net, mario.limonciello@....com,
	naveenkrishna.chatradhi@....com,
	platform-driver-x86@...r.kernel.org, suma.hegde@....com,
	tony.luck@...el.com, x86@...nel.org
Subject: Re: [PATCH v3 06/12] x86/amd_nb: Use topology info to get AMD node
 count

On Thu, Oct 23, 2025 at 05:01:07PM +0200, Michal Pecio wrote:
> On Thu, 23 Oct 2025 09:59:35 -0400, Yazen Ghannam wrote:
> > Thanks Michal.
> > 
> > I don't see anything obviously wrong.
> 
> Which code is responsible for setting up those bitmaps which
> are counted by topology_init_possible_cpus()?
> 
> I guess I could add some printks there and reboot.
> 

The kernel seems to think there are 6 CPUs on your system:

[    0.072059] CPU topo: Allowing 4 present CPUs plus 2 hotplug CPUs

We don't seem them enabled, but they may still get APIC IDs. If so, then
the IDs would be beyond the core shift of 2.

APIC IDs b'0 00 -> CPU0 on logical package 0
	 b'0 01 -> CPU1 on logical package 0
	 b'0 10 -> CPU2 on logical package 0
	 b'0 11 -> CPU3 on logical package 0
	 b'1 00 -> CPU0 on logical package 1
	 b'1 01 -> CPU1 on logical package 1


Please try booting with "possible_cpus=4".

The "number of possible CPUs" comes from the ACPI Multiple APIC
Description Table (MADT). This has the signature "APIC".

Can you please provide the disassembly of this table?

You can use the following commands:
1) Dump the ACPI tables to binaries:	"sudo acpidump -b"
2) Disassemble the APIC table:		"iasl -d apic.dat"

Both commands are part of the "acpica-tools" package.

[...]
> 
> BTW, I forgot to mention that I have a second seemingly identical
> board with same BIOS running Phenom X6 1090T. It is not affected.
> Not sure if this is helpful. I haven't tried swapping CPUs.

Can you please share the dmesg output from that system? And the ACPI
table too?

If the BIOS is the same, then I wonder if they hardcoded 6 CPUs in the
MADT then mark the extras as "not enabled" on parts with lower cores.

Thanks,
Yazen