linux-kernel - Re: [PATCH v1] net: phy: dp83867: Disable EEE support as not implemented

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b61689c-ac4a-402c-bbc8-2c1207e19c76@lunn.ch>
Date: Thu, 23 Oct 2025 19:01:34 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Emanuele Ghidoli <ghidoliemanuele@...il.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Emanuele Ghidoli <emanuele.ghidoli@...adex.com>,
	Russell King <linux@...linux.org.uk>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v1] net: phy: dp83867: Disable EEE support as not
 implemented

On Thu, Oct 23, 2025 at 04:48:53PM +0200, Emanuele Ghidoli wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>
> 
> While the DP83867 PHYs report EEE capability through their feature
> registers, the actual hardware does not support EEE (see Links).
> When the connected MAC enables EEE, it causes link instability and
> communication failures.
> 
> The issue is reproducible with a iMX8MP and relevant stmmac ethernet port.
> Since the introduction of phylink-managed EEE support in the stmmac driver,
> EEE is now enabled by default, leading to issues on systems using the
> DP83867 PHY.
> 
> Call phy_disable_eee during phy initialization to prevent EEE from being
> enabled on DP83867 PHYs.
> 
> Link: https://e2e.ti.com/support/interface-group/interface/f/interface-forum/1445244/dp83867ir-dp83867-disable-eee-lpi
> Link: https://e2e.ti.com/support/interface-group/interface/f/interface-forum/658638/dp83867ir-eee-energy-efficient-ethernet

Interesting statement this last one. "None of our gigabit PHYs
support EEE operation today."

I wounder if any of the other TI PHY drivers need this fix?

> Fixes: 2a10154abcb7 ("net: phy: dp83867: Add TI dp83867 phy")
> Cc: stable@...r.kernel.org
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@...adex.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew