linux-kernel - Re: [PATCH v5 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHUa44FCYnQ7EL8pXH-72ptENus7KZRvfE8Ym1vjN4QiVsVtqQ@mail.gmail.com>
Date: Thu, 23 Oct 2025 19:30:20 +0200
From: Jens Wiklander <jens.wiklander@...aro.org>
To: Bean Huo <huobean@...il.com>
Cc: avri.altman@....com, avri.altman@...disk.com, bvanassche@....org, 
	alim.akhtar@...sung.com, jejb@...ux.ibm.com, martin.petersen@...cle.com, 
	can.guo@....qualcomm.com, ulf.hansson@...aro.org, beanhuo@...ron.com, 
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for
 UFS devices

On Thu, Oct 23, 2025 at 5:09 PM Bean Huo <huobean@...il.com> wrote:
>
> On Thu, 2025-10-23 at 15:53 +0200, Jens Wiklander wrote:
> > > +       device_id = kasprintf(GFP_KERNEL, "%04X-%04X-%s-%s-%04X-%04X",
> > > +                             dev_info->wmanufacturerid, dev_info-
> > > >wspecversion,
> > > +                             dev_info->model, serial_hex, device_version,
> > > +                             manufacture_date);
> >
> >
> > The device ID is part of the ABI with the secure world or the firmware
> > we're serving. It might be worth adding a comment so the format isn't
> > changed without understanding the consequences.
> >
> > Cheers,
> > Jens
>
>
> Jens,
>
> I can add, do you have suggestion for this reminder message, for example:
>
> /*
>  * WARNING: This device ID format is part of the stable ABI between
>  * the kernel and secure world (OP-TEE). Any changes to this format
>  * must be coordinated with firmware updates to avoid breaking
>  * communication with the secure world.
>  */
>
> or
>
> /* Device ID format is ABI with secure world - do not change without firmware
> coordination */
>

The latter should be enough.

Thanks,
Jens