linux-kernel - Re: [PATCH v3 1/3] rtc: tegra: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPpug9kcQwQlhivK@smile.fi.intel.com>
Date: Thu, 23 Oct 2025 21:05:55 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Kartik Rajput <kkartik@...dia.com>
Cc: alexandre.belloni@...tlin.com, thierry.reding@...il.com,
	jonathanh@...dia.com, linux-rtc@...r.kernel.org,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] rtc: tegra: Use devm_clk_get_enabled() in probe

On Thu, Oct 23, 2025 at 03:00:40PM +0530, Kartik Rajput wrote:
> Simplify clock management by replacing devm_clk_get() and manual clock
> enable/disable with devm_clk_get_enabled(). This also simplifies the
> error handling logic.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
with the caveat that you need to remove ->remove() altogether as well.

-- 
With Best Regards,
Andy Shevchenko