linux-kernel - Re: [PATCH v4 0/2] dt-bindings: mmc: ti,omap2430-sdhci: Add json schema for the text binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+ZmvVHvmLYKQD0fn74+9WcnmDVAqC1Q48HFLVN35tuFQ@mail.gmail.com>
Date: Thu, 23 Oct 2025 13:22:31 -0500
From: Rob Herring <robh@...nel.org>
To: Charan Pedumuru <charan.pedumuru@...il.com>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Paul Barker <paul.barker@...cloud.com>, 
	Marc Murphy <marc.murphy@...cloud.com>, Tony Lindgren <tony@...mide.com>, 
	Kishon Vijay Abraham I <kishon@...nel.org>, linux-mmc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH v4 0/2] dt-bindings: mmc: ti,omap2430-sdhci: Add json
 schema for the text binding

On Thu, Oct 23, 2025 at 10:40 AM Charan Pedumuru
<charan.pedumuru@...il.com> wrote:
>
>
>
> On 20-10-2025 21:28, Rob Herring wrote:
> > On Mon, Oct 20, 2025 at 10:44 AM Charan Pedumuru
> > <charan.pedumuru@...il.com> wrote:
> >>
> >>
> >>
> >> On 20-10-2025 19:57, Rob Herring wrote:
> >>> On Sun, Oct 19, 2025 at 01:04:36PM +0000, Charan Pedumuru wrote:
> >>>> Create a YAML binding for ti,omap2430-sdhci and fix vmmc-supply
> >>>> property typo for a DTS file.
> >>>>
> >>>> Signed-off-by: Charan Pedumuru <charan.pedumuru@...il.com>
> >>>> ---
> >>>> Note: The property "ti,needs-special-reset" was not removed from DTS cause it will
> >>>>       disrupt the compilation for other compatibles as the node &mmc is used for all
> >>>>       compatibles for some DTS files.
> >>>
> >>> I don't understand. AFIACT, "ti,needs-special-reset" is only used for
> >>> the hsmmc driver/binding. But this series for for the sdhci
> >>> driver/binding. So shouldn't the property be removed from sdhci nodes
> >>> (and the binding), but kept for hsmmc nodes?
> >>
> >>
> >> Yes we can remove that property from sdhci , but &mmc node in DTS is common for all mmc drivers and this "ti,needs-special-reset" property is defined there for one board, so even when I remove it from DTSI for sdhci nodes, the DTS file still contains this property in &mmc node which is also common for other mmc drivers, so even if we remove that property for sdhci node, we still need to define it in YAML to resolve dtb_check. The issue here is not removing the property from sdhci node in DTSI file, but to remove it from &mmc node from a DTS file which is common to all mmc drivers.
> >>
> >> Here is the DTS node (ti/omap/am5729-beagleboneai.dts) which contain that property and is common for all mmc drivers.
> >> &mmc2 {
> >>         status = "okay";
> >>         vmmc-supply = <&vdd_1v8>;
> >>         vqmmc-supply = <&vdd_1v8>;
> >>         bus-width = <8>;
> >>         ti,non-removable;
> >>         non-removable;
> >>         mmc-pwrseq = <&emmc_pwrseq>;
> >>
> >>         ti,needs-special-reset;
> >>         dmas = <&sdma_xbar 47>, <&sdma_xbar 48>;
> >>         dma-names = "tx", "rx";
> >>
> >> };
> >
> > I'm pretty sure that's not how &mmc2 works and you are confused. I
> > would suggest you do a dtb->dts pass and compare the results.
>
> So, I can remove ti,needs-special-hs-handling and cap-mmc-dual-data-rate properties from a similar DTS file along with ti,needs-special-reset as these properties are not used for sdhci-omap driver and are no longer in use, I will remove these properties from YAML too, if this is true. Can you confirm this?

If the properties are not used in drivers or .dts files, then yes they
don't need to be in the schema.

I think you just need what you had previously and just drop the
changes to hsmmc nodes.

Rob