linux-kernel - Re: [PATCH 2/2] iio: position: Add support for ams AS5600 angle sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPp010RxM3Dp_fAd@smile.fi.intel.com>
Date: Thu, 23 Oct 2025 21:32:55 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>
Cc: Aditya Dutt <duttaditya18@...il.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Corbet <corbet@....net>, Frank Zago <frank@...o.net>,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH 2/2] iio: position: Add support for ams AS5600 angle
 sensor

On Thu, Oct 23, 2025 at 07:16:27PM +0100, Jonathan Cameron wrote:
> On Tue, 21 Oct 2025 01:46:53 +0530
> Aditya Dutt <duttaditya18@...il.com> wrote:

...

> > +		if (chan->channel == 0) {
> > +			/* Whole angle range = 2*pi / 4096 */
> > +			*val = 2 * 3141592;

Can you, please, add a definition of PI * 10^6 to units.h? We have already
users of this value and of the PI * 10^5.

...

> > +			/* Partial angle = (range / 4096) * (2*pi / 4096) */
> Use multi line comment syntax for htis.

Also you may use Greek PI (as unicode character) in the comments and messages.
We've been living decades in the unicode time!

-- 
With Best Regards,
Andy Shevchenko