linux-kernel - Re: [PATCH v12 07/31] x86,fs/resctrl: Rename struct rdt_mon_domain and rdt_hw_mon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b9d5e86-b858-4fce-adc2-e5adae25e775@intel.com>
Date: Wed, 22 Oct 2025 21:18:51 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v12 07/31] x86,fs/resctrl: Rename struct rdt_mon_domain
 and rdt_hw_mon_domain

Hi Tony,

On 10/13/25 3:33 PM, Tony Luck wrote:
> The upcoming telemetry event monitoring are not tied to the L3
> resource and will have a new domain structures.
> 
> Rename the L3 resource specific domain data structures to include
> "l3_" in their names to avoid confusion between the different
> resource specific domain structures:
> rdt_mon_domain		-> rdt_l3_mon_domain
> rdt_hw_mon_domain	-> rdt_hw_l3_mon_domain
> 
> No functional change.
> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Some style hiccups with the changes added since the RB tag:

...

> @@ -242,9 +242,9 @@ int resctrl_arch_rmid_read(struct rdt_resource *r, struct rdt_domain_hdr *hdr,
>  			   u32 unused, u32 rmid, enum resctrl_event_id eventid,
>  			   u64 *val, void *ignored)
>  {
> -	struct rdt_hw_mon_domain *hw_dom;
> +	struct rdt_hw_l3_mon_domain *hw_dom;
>  	struct arch_mbm_state *am;
> -	struct rdt_mon_domain *d;
> +	struct rdt_l3_mon_domain *d;

This is a new hunk and it needs to change to maintain reverse fir order.

>  	u64 msr_val;
>  	u32 prmid;
>  	int cpu;

...

> @@ -3194,7 +3194,7 @@ static int mon_add_all_files(struct kernfs_node *kn, struct rdt_domain_hdr *hdr,
>  			     bool do_sum)
>  {
>  	struct rmid_read rr = {0};
> -	struct rdt_mon_domain *d;
> +	struct rdt_l3_mon_domain *d;
>  	struct mon_data *priv;
>  	struct mon_evt *mevt;
>  	int ret, domid;

Another new hunk that needs to change to maintain reverse fir order.

Reinette