linux-kernel - Re: [PATCH net-next v5 0/7] net: dsa: lantiq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b379440-be1a-4a2c-86e0-9d69d6835095@hauke-m.de>
Date: Thu, 23 Oct 2025 21:04:03 +0200
From: Hauke Mehrtens <hauke@...ke-m.de>
To: Daniel Golle <daniel@...rotopia.org>, Andrew Lunn <andrew@...n.ch>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Andreas Schirm <andreas.schirm@...mens.com>,
 Lukas Stockmann <lukas.stockmann@...mens.com>,
 Alexander Sverdlin <alexander.sverdlin@...mens.com>,
 Peter Christen <peter.christen@...mens.com>,
 Avinash Jayaraman <ajayaraman@...linear.com>, Bing tao Xu
 <bxu@...linear.com>, Liang Xu <lxu@...linear.com>,
 Juraj Povazanec <jpovazanec@...linear.com>,
 "Fanni (Fang-Yi) Chan" <fchan@...linear.com>,
 "Benny (Ying-Tsan) Weng" <yweng@...linear.com>,
 "Livia M. Rosu" <lrosu@...linear.com>, John Crispin <john@...ozen.org>
Subject: Re: [PATCH net-next v5 0/7] net: dsa: lantiq_gswip: use regmap for
 register access

On 10/21/25 13:16, Daniel Golle wrote:
> This series refactors the lantiq_gswip driver to utilize the regmap API
> for register access, replacing the previous approach of open-coding
> register operations.
> 
> Using regmap paves the way for supporting different busses to access the
> switch registers, for example it makes it easier to use an MDIO-based
> method required to access the registers of the MaxLinear GSW1xx series
> of dedicated switch ICs.
> 
> Apart from that, the use of regmap improves readability and
> maintainability of the driver by standardizing register access.
> 
> When ever possible changes were made using Coccinelle semantic patches,
> sometimes adjusting white space and adding line breaks when needed.
> The remaining changes which were not done using semantic patches are
> small and should be easy to review and verify.
> 
> The whole series has been
> Tested-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> ---
> Changes since v4:
>   * use REGMAP_UPSHIFT(2) macro instead of -2 value for reg_shift
> 
> Changes since v3:
>   * unlock mutex in error path
>   * simplify some of the manually converted register reads by changing
>     the type to u32 instead of using a u32 tmp variable and then assigning
>     the value to the previously used u16 variable.
> 
> Changes since v2:
>   * correctly target net-next tree (fix typo in subject)
> 
> Changes since RFC:
>   * drop error handling, it wasn't there before and it would anyway be
>     removed again by a follow-up change
>   * optimize more of the regmap_write_bits() calls
> 
> 
> Daniel Golle (7):
>    net: dsa: lantiq_gswip: clarify GSWIP 2.2 VLAN mode in comment
>    net: dsa: lantiq_gswip: convert accessors to use regmap
>    net: dsa: lantiq_gswip: convert trivial accessor uses to regmap
>    net: dsa: lantiq_gswip: manually convert remaining uses of read
>      accessors
>    net: dsa: lantiq_gswip: replace *_mask() functions with regmap API
>    net: dsa: lantiq_gswip: optimize regmap_write_bits() statements
>    net: dsa: lantiq_gswip: harmonize gswip_mii_mask_*() parameters
> 
>   drivers/net/dsa/lantiq/Kconfig        |   1 +
>   drivers/net/dsa/lantiq/lantiq_gswip.c | 471 +++++++++++++-------------
>   drivers/net/dsa/lantiq/lantiq_gswip.h |   6 +-
>   3 files changed, 243 insertions(+), 235 deletions(-)
> 
I reviewed the series and it looks good to me.

Acked-by; Hauke Mehrtens <hauke@...ke-m.de>