linux-kernel - Re: [PATCH v3] init/main.c: Wrap long kernel cmdline when printing to logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251023123709.e6517087325a3a53221029d9@linux-foundation.org>
Date: Thu, 23 Oct 2025 12:37:09 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Douglas Anderson <dianders@...omium.org>
Cc: linux-kernel@...r.kernel.org, linux-s390 <linux-s390@...r.kernel.org>,
 Randy Dunlap <rdunlap@...radead.org>, Andrew Chant <achant@...gle.com>,
 Geert Uytterhoeven <geert@...ux-m68k.org>, Heiko Carstens
 <hca@...ux.ibm.com>, "Paul E . McKenney" <paulmck@...nel.org>, Sven
 Schnelle <svens@...ux.ibm.com>, Alexander Shishkin
 <alexander.shishkin@...ux.intel.com>, Brian Gerst <brgerst@...il.com>,
 Christian Brauner <brauner@...nel.org>, Francesco Valla
 <francesco@...la.it>, Guo Weikang <guoweikang.kernel@...il.com>, Huacai
 Chen <chenhuacai@...nel.org>, Ingo Molnar <mingo@...nel.org>, Jan Hendrik
 Farr <kernel@...rr.cc>, Jeff Xu <jeffxu@...omium.org>, Kees Cook
 <kees@...nel.org>, Masahiro Yamada <masahiroy@...nel.org>, Michal
 Koutný <mkoutny@...e.com>, Miguel Ojeda
 <ojeda@...nel.org>, "Mike Rapoport (Microsoft)" <rppt@...nel.org>, Nathan
 Chancellor <nathan@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Shakeel Butt <shakeel.butt@...ux.dev>, Tejun Heo <tj@...nel.org>, Thomas
 Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v3] init/main.c: Wrap long kernel cmdline when printing
 to logs

On Thu, 23 Oct 2025 11:33:05 -0700 Douglas Anderson <dianders@...omium.org> wrote:

>
> Add wrapping to the printout of the kernel command line.
>

Spose so.

>
>
>  init/Kconfig | 18 ++++++++++
>  init/main.c  | 96 +++++++++++++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 113 insertions(+), 1 deletion(-)

It seems like a lot of fuss for a small problem.  But this:

--- a/init/main.c~init-mainc-wrap-long-kernel-cmdline-when-printing-to-logs-fix
+++ a/init/main.c
@@ -944,7 +944,7 @@ static void __init early_numa_node_init(
  *   Kernel command line: jumps over the \
  *   Kernel command line: lazy dog."
  */
-static void print_kernel_cmdline(const char *cmdline)
+static void __init print_kernel_cmdline(const char *cmdline)
 {
 	size_t len;

_

will make it a whole lot more palatable, no?