linux-kernel - Re: [PATCH RESEND] drm/tegra: dc: fix reference leak in tegra_dc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2620730.K71DO8KEF6@senjougahara>
Date: Thu, 23 Oct 2025 13:32:56 +0900
From: Mikko Perttunen <mperttunen@...dia.com>
To: thierry.reding@...il.com, airlied@...il.com, simona@...ll.ch,
 jonathanh@...dia.com, Ma Ke <make24@...as.ac.cn>
Cc: dri-devel@...ts.freedesktop.org, linux-tegra@...r.kernel.org,
 linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
 Ma Ke <make24@...as.ac.cn>, stable@...r.kernel.org
Subject:
 Re: [PATCH RESEND] drm/tegra: dc: fix reference leak in tegra_dc_couple()

On Wednesday, October 22, 2025 8:47 PM Ma Ke wrote:
> driver_find_device() calls get_device() to increment the reference
> count once a matching device is found, but there is no put_device() to
> balance the reference count. To avoid reference count leakage, add
> put_device() to decrease the reference count.
> 
> Found by code review.
> 
> Cc: stable@...r.kernel.org
> Fixes: a31500fe7055 ("drm/tegra: dc: Restore coupling of display controllers")
> Signed-off-by: Ma Ke <make24@...as.ac.cn>
> ---
>  drivers/gpu/drm/tegra/dc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
> index 59d5c1ba145a..6c84bd69b11f 100644
> --- a/drivers/gpu/drm/tegra/dc.c
> +++ b/drivers/gpu/drm/tegra/dc.c
> @@ -3148,6 +3148,7 @@ static int tegra_dc_couple(struct tegra_dc *dc)
>  		dc->client.parent = &parent->client;
>  
>  		dev_dbg(dc->dev, "coupled to %s\n", dev_name(companion));
> +		put_device(companion);
>  	}
>  
>  	return 0;
> 

Acked-by: Mikko Perttunen <mperttunen@...dia.com>