[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e673afcf-fc43-4227-aa9c-bdfdf5561cb3@intel.com>
Date: Wed, 22 Oct 2025 21:35:30 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
<Dave.Martin@....com>, Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
<patches@...ts.linux.dev>
Subject: Re: [PATCH v12 17/31] x86/resctrl: Find and enable usable telemetry
events
Hi Tony,
On 10/13/25 3:33 PM, Tony Luck wrote:
> The INTEL_PMT_TELEMETRY driver provides telemetry region structures of the
> types requested by resctrl.
>
> Scan these structures to discover which pass sanity checks to derive
> a list of valid regions:
>
> 1) They have guid known to resctrl.
> 2) They have a valid package ID.
> 3) The enumerated size of the MMIO region matches the expected
> value from the XML description file.
>
> Mark regions that fail any of these checks as unusable.
Above needs an update to reflect new design that will even mark
regions that have known guid as unusable. So far the changelogs and
comments do not reflect the new design and will make this implementation
harder to understand for folks not familiar with its evolution.
Reinette
Powered by blists - more mailing lists