linux-kernel - RE: [PATCH] arm64: dts: toshiba: tmpv7708: Align node names with DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <TY7PR01MB14818346842A5155C5D82797DCDF0A@TY7PR01MB14818.jpnprd01.prod.outlook.com>
Date: Thu, 23 Oct 2025 00:37:24 +0000
From: <nobuhiro.iwamatsu.x90@...l.toshiba>
To: <krzysztof.kozlowski@...aro.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] arm64: dts: toshiba: tmpv7708: Align node names with DT
 bindings

Hi Krzysztof,

Thanks for your patch.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Wednesday, October 22, 2025 10:36 PM
> To: iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro.iwamatsu.x90@...l.toshiba>; Rob Herring <robh@...nel.org>;
> Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley
> <conor+dt@...nel.org>; linux-arm-kernel@...ts.infradead.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Subject: [PATCH] arm64: dts: toshiba: tmpv7708: Align node names with DT
> bindings
> 
> DT bindings expect node names to follow certain pattern, dtbs_check
> warnings:
> 
>   tmpv7708-rm-mbrc.dtb: pmux@...90000 (toshiba,tmpv7708-pinctrl):
>     'pwm_mux' does not match any of the regexes: '-pins$', '^pinctrl-[0-9]+$'
>   tmpv7708-rm-mbrc.dtb pmux@...90000 (toshiba,tmpv7708-pinctrl):
>     $nodename:0: 'pmux@...90000' does not match
> '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
>   tmpv7708-rm-mbrc.dtb: wdt@...30000 (toshiba,visconti-wdt):
>     $nodename:0: 'wdt@...30000' does not match
> '^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@...l.toshiba>

Best regards,
  Nobuhiro

> ---
>  arch/arm64/boot/dts/toshiba/tmpv7708.dtsi      | 4 ++--
>  arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> index 9aa7b1872bd6..88e38d6efcaa 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708.dtsi
> @@ -161,7 +161,7 @@ gic: interrupt-controller@...01000 {
>  			      <0 0x24006000 0 0x2000>;
>  		};
> 
> -		pmux: pmux@...90000 {
> +		pmux: pinctrl@...90000 {
>  			compatible = "toshiba,tmpv7708-pinctrl";
>  			reg = <0 0x24190000 0 0x10000>;
>  		};
> @@ -463,7 +463,7 @@ piether: ethernet@...00000 {
>  			status = "disabled";
>  		};
> 
> -		wdt: wdt@...30000 {
> +		wdt: watchdog@...30000 {
>  			compatible = "toshiba,visconti-wdt";
>  			reg = <0 0x28330000 0 0x1000>;
>  			clocks = <&pismu TMPV770X_CLK_WDTCLK>; diff
> --git a/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi
> b/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi
> index a480c6ba5f5d..5ea835fe08a8 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708_pins.dtsi
> @@ -91,7 +91,7 @@ i2c8_pins: i2c8-pins {
>  		bias-pull-up;
>  	};
> 
> -	pwm_mux: pwm_mux {
> +	pwm_mux: pwm-pins {
>  		function = "pwm";
>  	};
> 
> --
> 2.48.1