linux-kernel - Re: [PATCH] perf hwmon_pmu: Fix uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPqjMzxyYeKCp91K@google.com>
Date: Thu, 23 Oct 2025 14:50:43 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Michal Suchanek <msuchanek@...e.de>
Cc: linux-perf-users@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Thomas Richter <tmricht@...ux.ibm.com>,
	linux-kernel@...r.kernel.org, Tony Jones <tonyj@...e.de>
Subject: Re: [PATCH] perf hwmon_pmu: Fix uninitialized variable warning

Hello,

On Wed, Oct 22, 2025 at 12:38:35PM +0200, Michal Suchanek wrote:
> The line_len is only set on success. Check the return value instead.

Can you please share the actual warning messages from the compiler?

Thanks,
Namhyung

> 
> Fixes: 53cc0b351ec9 ("perf hwmon_pmu: Add a tool PMU exposing events from hwmon in sysfs")
> Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> ---
>  tools/perf/util/hwmon_pmu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/hwmon_pmu.c b/tools/perf/util/hwmon_pmu.c
> index 416dfea9ffff..5c27256a220a 100644
> --- a/tools/perf/util/hwmon_pmu.c
> +++ b/tools/perf/util/hwmon_pmu.c
> @@ -742,8 +742,7 @@ int perf_pmus__read_hwmon_pmus(struct list_head *pmus)
>  			continue;
>  		}
>  		io__init(&io, name_fd, buf2, sizeof(buf2));
> -		io__getline(&io, &line, &line_len);
> -		if (line_len > 0 && line[line_len - 1] == '\n')
> +		if (io__getline(&io, &line, &line_len) > 0 && line[line_len - 1] == '\n')
>  			line[line_len - 1] = '\0';
>  		hwmon_pmu__new(pmus, buf, class_hwmon_ent->d_name, line);
>  		close(name_fd);
> -- 
> 2.51.0
>