linux-kernel - Re: [PATCH] vdpa/pds: use %pe for ERR_PTR() in event handler registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53d8d0e0-d7d7-481d-8f86-2a71c6503362@amd.com>
Date: Thu, 23 Oct 2025 15:24:51 -0700
From: Brett Creeley <bcreeley@....com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, shannon.nelson@....com,
 brett.creeley@....com, eperezma@...hat.com, mst@...hat.com,
 jasowang@...hat.com, xuanzhuo@...ux.alibaba.com,
 virtualization@...ts.linux.dev
Cc: alok.a.tiwarilinux@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vdpa/pds: use %pe for ERR_PTR() in event handler
 registration



On 10/18/2025 10:46 AM, Alok Tiwari wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> Use %pe instead of %ps when printing ERR_PTR() values. %ps is intended
> for string pointers, while %pe correctly prints symbolic error names
> for error pointers returned via ERR_PTR().
> This shows the returned error value more clearly.
> 
> Fixes: 67f27b8b3a34 ("pds_vdpa: subscribe to the pds_core events")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
>   drivers/vdpa/pds/vdpa_dev.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

LGTM. Thanks.

Reviewed-by: Brett Creeley <brett.creeley@....com>

> 
> diff --git a/drivers/vdpa/pds/vdpa_dev.c b/drivers/vdpa/pds/vdpa_dev.c
> index 36f61cc96e21..43426bd971ac 100644
> --- a/drivers/vdpa/pds/vdpa_dev.c
> +++ b/drivers/vdpa/pds/vdpa_dev.c
> @@ -51,7 +51,7 @@ static int pds_vdpa_register_event_handler(struct pds_vdpa_device *pdsv)
>                  err = pdsc_register_notify(nb);
>                  if (err) {
>                          nb->notifier_call = NULL;
> -                       dev_err(dev, "failed to register pds event handler: %ps\n",
> +                       dev_err(dev, "failed to register pds event handler: %pe\n" >                                  ERR_PTR(err));
>                          return -EINVAL;
>                  }
> --
> 2.50.1
>