linux-kernel - Re: [PATCH v2 1/1] drm/sti: hdmi: call drm_edid_connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPqxjUh91I4G4bOm@thinkstation>
Date: Fri, 24 Oct 2025 00:51:57 +0200
From: Raphaël Gallais-Pou <rgallaispou@...il.com>
To: Jani Nikula <jani.nikula@...ux.intel.com>
Cc: Chu Guangqing <chuguangqing@...pur.com>, alain.volmat@...s.st.com,
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] drm/sti: hdmi: call drm_edid_connector_update
 when edid is NULL

Le Tue, Oct 21, 2025 at 11:55:01AM +0300, Jani Nikula a écrit :
> On Mon, 20 Oct 2025, Chu Guangqing <chuguangqing@...pur.com> wrote:
> > call drm_edid_connector_update to reset the information when edid is NULL.
> > We can see the following comments in drm_edid.c
> > If EDID is NULL, reset the information.
> >
> > Signed-off-by: Chu Guangqing <chuguangqing@...pur.com>
> > ---
> >  drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> > index 4e7c3d78b2b9..e0be1be8bcdd 100644
> > --- a/drivers/gpu/drm/sti/sti_hdmi.c
> > +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> > @@ -1008,7 +1008,7 @@ static int sti_hdmi_connector_get_modes(struct drm_connector *connector)
> >  	return count;
> >  
> >  fail:
> > -	DRM_ERROR("Can't read HDMI EDID\n");
> > +	drm_edid_connector_update(connector, NULL);
> 
> The context above has:
> 
> 	drm_edid = drm_edid_read(connector);
> 
> 	drm_edid_connector_update(connector, drm_edid);
> 
> 	cec_notifier_set_phys_addr(hdmi->notifier,
> 				   connector->display_info.source_physical_address);
> 
> 	if (!drm_edid)
> 		goto fail;
> 
> i.e. drm_edid_connector_update() already gets called regardless of
> whether drm_edid is NULL or not. Precisely as intended in commit
> f7945d9fa8b7 ("drm/sti/sti_hdmi: convert to struct drm_edid").

Woops indeed you are right.  Looks like I was distracted during the
review.

Sorry but looking at it again this patch has no mean to be.  Regarding
the noisy message, I'll send one removing it, but it is not pressing
IMHO.  It only appears if the driver probe with connector plugged.

Thanks for your reply Jani,

Best regards,
Raphaël
> 
> 
> BR,
> Jani.
> 
> 
> >  	return 0;
> >  }
> 
> -- 
> Jani Nikula, Intel