| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <c78d7370-85c-2651-c4be-9b9880ec2b15@inria.fr>
Date: Thu, 23 Oct 2025 13:03:38 +0800 (+08)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Harsh Jain <h.jain@....com>, Herbert Xu <herbert@...dor.apana.org.au>,
Mounika Botcha <mounika.botcha@....com>
cc: linux-kernel@...r.kernel.org, oe-kbuild-all@...ts.linux.dev
Subject: drivers/crypto/xilinx/xilinx-trng.c:336:54-61: WARNING: Consider
using %pe to print PTR_ERR() (fwd)
---------- Forwarded message ----------
Date: Thu, 23 Oct 2025 12:35:11 +0800
From: kernel test robot <lkp@...el.com>
To: oe-kbuild@...ts.linux.dev
Cc: lkp@...el.com, Julia Lawall <julia.lawall@...ia.fr>
Subject: drivers/crypto/xilinx/xilinx-trng.c:336:54-61: WARNING: Consider using
%pe to print PTR_ERR()
BCC: lkp@...el.com
CC: oe-kbuild-all@...ts.linux.dev
CC: linux-kernel@...r.kernel.org
TO: Harsh Jain <h.jain@....com>
CC: Herbert Xu <herbert@...dor.apana.org.au>
CC: Mounika Botcha <mounika.botcha@....com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 43e9ad0c55a369ecc84a4788d06a8a6bfa634f1c
commit: 8979744aca8096ee5072798dfc1181606919b35d crypto: xilinx - Add TRNG driver for Versal
date: 7 weeks ago
:::::: branch date: 3 hours ago
:::::: commit date: 7 weeks ago
config: powerpc64-randconfig-r064-20251023 (https://download.01.org/0day-ci/archive/20251023/202510231229.Z6TduqZy-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 754ebc6ebb9fb9fbee7aef33478c74ea74949853)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Julia Lawall <julia.lawall@...ia.fr>
| Closes: https://lore.kernel.org/r/202510231229.Z6TduqZy-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/crypto/xilinx/xilinx-trng.c:336:54-61: WARNING: Consider using %pe to print PTR_ERR()
vim +336 drivers/crypto/xilinx/xilinx-trng.c
8979744aca8096 Harsh Jain 2025-08-25 323
8979744aca8096 Harsh Jain 2025-08-25 324 static int xtrng_probe(struct platform_device *pdev)
8979744aca8096 Harsh Jain 2025-08-25 325 {
8979744aca8096 Harsh Jain 2025-08-25 326 struct xilinx_rng *rng;
8979744aca8096 Harsh Jain 2025-08-25 327 int ret;
8979744aca8096 Harsh Jain 2025-08-25 328
8979744aca8096 Harsh Jain 2025-08-25 329 rng = devm_kzalloc(&pdev->dev, sizeof(*rng), GFP_KERNEL);
8979744aca8096 Harsh Jain 2025-08-25 330 if (!rng)
8979744aca8096 Harsh Jain 2025-08-25 331 return -ENOMEM;
8979744aca8096 Harsh Jain 2025-08-25 332
8979744aca8096 Harsh Jain 2025-08-25 333 rng->dev = &pdev->dev;
8979744aca8096 Harsh Jain 2025-08-25 334 rng->rng_base = devm_platform_ioremap_resource(pdev, 0);
8979744aca8096 Harsh Jain 2025-08-25 335 if (IS_ERR(rng->rng_base)) {
8979744aca8096 Harsh Jain 2025-08-25 @336 dev_err(&pdev->dev, "Failed to map resource %ld\n", PTR_ERR(rng->rng_base));
8979744aca8096 Harsh Jain 2025-08-25 337 return PTR_ERR(rng->rng_base);
8979744aca8096 Harsh Jain 2025-08-25 338 }
8979744aca8096 Harsh Jain 2025-08-25 339
8979744aca8096 Harsh Jain 2025-08-25 340 xtrng_trng_reset(rng->rng_base);
8979744aca8096 Harsh Jain 2025-08-25 341 ret = xtrng_reseed_internal(rng);
8979744aca8096 Harsh Jain 2025-08-25 342 if (ret) {
8979744aca8096 Harsh Jain 2025-08-25 343 dev_err(&pdev->dev, "TRNG Seed fail\n");
8979744aca8096 Harsh Jain 2025-08-25 344 return ret;
8979744aca8096 Harsh Jain 2025-08-25 345 }
8979744aca8096 Harsh Jain 2025-08-25 346
8979744aca8096 Harsh Jain 2025-08-25 347 xilinx_rng_dev = rng;
8979744aca8096 Harsh Jain 2025-08-25 348 mutex_init(&rng->lock);
8979744aca8096 Harsh Jain 2025-08-25 349 ret = crypto_register_rng(&xtrng_trng_alg);
8979744aca8096 Harsh Jain 2025-08-25 350 if (ret) {
8979744aca8096 Harsh Jain 2025-08-25 351 dev_err(&pdev->dev, "Crypto Random device registration failed: %d\n", ret);
8979744aca8096 Harsh Jain 2025-08-25 352 return ret;
8979744aca8096 Harsh Jain 2025-08-25 353 }
8979744aca8096 Harsh Jain 2025-08-25 354 ret = xtrng_hwrng_register(&rng->trng);
8979744aca8096 Harsh Jain 2025-08-25 355 if (ret) {
8979744aca8096 Harsh Jain 2025-08-25 356 dev_err(&pdev->dev, "HWRNG device registration failed: %d\n", ret);
8979744aca8096 Harsh Jain 2025-08-25 357 goto crypto_rng_free;
8979744aca8096 Harsh Jain 2025-08-25 358 }
8979744aca8096 Harsh Jain 2025-08-25 359 platform_set_drvdata(pdev, rng);
8979744aca8096 Harsh Jain 2025-08-25 360
8979744aca8096 Harsh Jain 2025-08-25 361 return 0;
8979744aca8096 Harsh Jain 2025-08-25 362
8979744aca8096 Harsh Jain 2025-08-25 363 crypto_rng_free:
8979744aca8096 Harsh Jain 2025-08-25 364 crypto_unregister_rng(&xtrng_trng_alg);
8979744aca8096 Harsh Jain 2025-08-25 365
8979744aca8096 Harsh Jain 2025-08-25 366 return ret;
8979744aca8096 Harsh Jain 2025-08-25 367 }
8979744aca8096 Harsh Jain 2025-08-25 368
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists