linux-kernel - Re: [PATCH v7 5/9] platform/x86: asus-wmi: Add support for multiple kbd led handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <CAGwozwGDBj2e83JBW71G_z6hMD5PsOXTQLqFVdPKZ6sU54tsGw@mail.gmail.com>
Date: Thu, 23 Oct 2025 08:56:37 +0200
From: Antheas Kapenekakis <lkml@...heas.dev>
To: kernel test robot <lkp@...el.com>
Cc: platform-driver-x86@...r.kernel.org, linux-input@...r.kernel.org,
	oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
	Corentin Chary <corentin.chary@...il.com>,
 "Luke D . Jones" <luke@...nes.dev>,
	Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Denis Benato <benato.denis96@...il.com>
Subject: Re: [PATCH v7 5/9] platform/x86: asus-wmi: Add support for multiple
 kbd led handlers

On Wed, 22 Oct 2025 at 15:38, kernel test robot <lkp@...el.com> wrote:
>
> Hi Antheas,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on 3a8660878839faadb4f1a6dd72c3179c1df56787]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Antheas-Kapenekakis/HID-asus-simplify-RGB-init-sequence/20251018-182410
> base:   3a8660878839faadb4f1a6dd72c3179c1df56787
> patch link:    https://lore.kernel.org/r/20251018101759.4089-6-lkml%40antheas.dev
> patch subject: [PATCH v7 5/9] platform/x86: asus-wmi: Add support for multiple kbd led handlers
> config: i386-randconfig-141-20251020 (https://download.01.org/0day-ci/archive/20251022/202510222013.EBLC609m-lkp@intel.com/config)
> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202510222013.EBLC609m-lkp@intel.com/
>
> New smatch warnings:
> drivers/platform/x86/asus-wmi.c:1623 kbd_led_update_all() warn: always true condition '(value >= 0) => (0-u32max >= 0)'
>
> Old smatch warnings:
> drivers/platform/x86/asus-wmi.c:2288 asus_new_rfkill() warn: '*rfkill' is an error pointer or valid
>
> vim +1623 drivers/platform/x86/asus-wmi.c
>
>   1589
>   1590  static void kbd_led_update_all(struct work_struct *work)
>   1591  {
>   1592          enum led_brightness value;
>   1593          struct asus_wmi *asus;
>   1594          bool registered, notify;
>   1595          int ret;
                              /\ value should have been an int and
placed here. It can take the value -1 hence the check

Are there any other comments on the series?

The only issue I am aware of is that Denis identified a bug in asusd
(asusctl userspace program daemon) in certain Asus G14/G16 laptops
that cause laptop keys to become sticky, I have had users also report
that bug in previous versions of the series. WIthout asusd running,
keyboards work fine incl. with brightness control (did not work
before). Given it will take two months for this to reach mainline, I
think it is a fair amount of time to address the bug.

Antheas

>   1596
>   1597          asus = container_of(work, struct asus_wmi, kbd_led_work);
>   1598
>   1599          scoped_guard(spinlock_irqsave, &asus_ref.lock) {
>   1600                  registered = asus->kbd_led_registered;
>   1601                  value = asus->kbd_led_wk;
>   1602                  notify = asus->kbd_led_notify;
>   1603          }
>   1604
>   1605          if (!registered) {
>   1606                  /*
>   1607                   * This workqueue runs under asus-wmi, which means probe has
>   1608                   * completed and asus-wmi will keep running until it finishes.
>   1609                   * Therefore, we can safely register the LED without holding
>   1610                   * a spinlock.
>   1611                   */
>   1612                  ret = devm_led_classdev_register(&asus->platform_device->dev,
>   1613                                              &asus->kbd_led);
>   1614                  if (!ret) {
>   1615                          scoped_guard(spinlock_irqsave, &asus_ref.lock)
>   1616                                  asus->kbd_led_registered = true;
>   1617                  } else {
>   1618                          pr_warn("Failed to register keyboard backlight LED: %d\n", ret);
>   1619                          return;
>   1620                  }
>   1621          }
>   1622
> > 1623          if (value >= 0)
>   1624                  do_kbd_led_set(&asus->kbd_led, value);
>   1625          if (notify) {
>   1626                  scoped_guard(spinlock_irqsave, &asus_ref.lock)
>   1627                          asus->kbd_led_notify = false;
>   1628                  led_classdev_notify_brightness_hw_changed(&asus->kbd_led, value);
>   1629          }
>   1630  }
>   1631
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>