linux-kernel - Re: [PATCH 2/2] ASoC: fsl_micfil: correct the endian format for DSD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZB+rFudpHB7TKFOCumh4Ni9q-421X3jRL2y8UbV74e-xQ@mail.gmail.com>
Date: Thu, 23 Oct 2025 10:12:39 +0300
From: Daniel Baluta <daniel.baluta@...il.com>
To: Shengjiu Wang <shengjiu.wang@....com>
Cc: shengjiu.wang@...il.com, Xiubo.Lee@...il.com, festevam@...il.com, 
	nicoleotsuka@...il.com, lgirdwood@...il.com, broonie@...nel.org, 
	perex@...ex.cz, tiwai@...e.com, linux-sound@...r.kernel.org, 
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ASoC: fsl_micfil: correct the endian format for DSD

oldest - > most significant bit.

With that,

Reviewed-by: Daniel Baluta <daniel.baluta@....com>


On Thu, Oct 23, 2025 at 9:48 AM Shengjiu Wang <shengjiu.wang@....com> wrote:
>
> The DSD format supported by micfil is that oldest bit is in bit 31, so
> the format should be DSD little endian format.
>
> Fixes: 21aa330fec31 ("ASoC: fsl_micfil: Add decimation filter bypass mode support")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> ---
>  sound/soc/fsl/fsl_micfil.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c
> index aabd90a8b3ec..cac26ba0aa4b 100644
> --- a/sound/soc/fsl/fsl_micfil.c
> +++ b/sound/soc/fsl/fsl_micfil.c
> @@ -131,7 +131,7 @@ static struct fsl_micfil_soc_data fsl_micfil_imx943 = {
>         .fifos = 8,
>         .fifo_depth = 32,
>         .dataline =  0xf,
> -       .formats = SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_DSD_U32_BE,
> +       .formats = SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_DSD_U32_LE,
>         .use_edma = true,
>         .use_verid = true,
>         .volume_sx = false,
> @@ -823,7 +823,7 @@ static int fsl_micfil_hw_params(struct snd_pcm_substream *substream,
>                 break;
>         }
>
> -       if (format == SNDRV_PCM_FORMAT_DSD_U32_BE) {
> +       if (format == SNDRV_PCM_FORMAT_DSD_U32_LE) {
>                 micfil->dec_bypass = true;
>                 /*
>                  * According to equation 29 in RM:
> --
> 2.34.1
>
>