linux-kernel - [PATCH usb-testing] usb: typec: ps883x: Fix missing mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20251023-topic-ps883x_fixup-v1-1-2afb5b85f09b@oss.qualcomm.com>
Date: Thu, 23 Oct 2025 10:13:42 +0200
From: Konrad Dybcio <konradybcio@...nel.org>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Jack Pham <jack.pham@....qualcomm.com>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
 kernel test robot <lkp@...el.com>, Dan Carpenter <dan.carpenter@...aro.org>
Subject: [PATCH usb-testing] usb: typec: ps883x: Fix missing mutex_unlock()

From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

There's a missing mutex_unlock() in the error-return path inside
ps883x_sw_set(). Simply delete that return since there's another one
3 lines below.

Fixes: f83cb615cb7a ("usb: typec: ps883x: Cache register settings, not Type-C mode")
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
Closes: https://lore.kernel.org/r/202510231023.aJ09O6pk-lkp@intel.com/
Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
---
 drivers/usb/typec/mux/ps883x.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/usb/typec/mux/ps883x.c b/drivers/usb/typec/mux/ps883x.c
index 7c61629b36d6..5f2879749769 100644
--- a/drivers/usb/typec/mux/ps883x.c
+++ b/drivers/usb/typec/mux/ps883x.c
@@ -192,10 +192,8 @@ static int ps883x_sw_set(struct typec_switch_dev *sw,
 		ret = regmap_assign_bits(retimer->regmap, REG_USB_PORT_CONN_STATUS_0,
 					 CONN_STATUS_0_ORIENTATION_REVERSED,
 					 orientation == TYPEC_ORIENTATION_REVERSE);
-		if (ret) {
+		if (ret)
 			dev_err(&retimer->client->dev, "failed to set orientation: %d\n", ret);
-			return ret;
-		}
 	}
 
 	mutex_unlock(&retimer->lock);

---
base-commit: 93741bd104ce07a790519ecee3a331ee7cf61ae3
change-id: 20251023-topic-ps883x_fixup-67dc74f23a9e

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@....qualcomm.com>