linux-kernel - RE: [PATCH v5 3/3] irqchip: aspeed: add compatible strings for ast2700-intc0-ic and ast2700-intc1-ic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY2PPF5CB9A1BE69A2BDA1BC2C78A7FFFCDF2F0A@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com>
Date: Thu, 23 Oct 2025 08:29:29 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
	"jk@...econstruct.com.au" <jk@...econstruct.com.au>, Kevin Chen
	<kevin_chen@...eedtech.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>
Subject: RE: [PATCH v5 3/3] irqchip: aspeed: add compatible strings for
 ast2700-intc0-ic and ast2700-intc1-ic

> Subject: Re: [PATCH v5 3/3] irqchip: aspeed: add compatible strings for
> ast2700-intc0-ic and ast2700-intc1-ic
> 
> On Wed, Oct 22 2025 at 14:55, Ryan Chen wrote:
> 
> The subject prefix is: irqchip/aspeed-intc:
> 
> It's documented how to make them:
> 
> 
> https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-su
> bject

Thanks, will fix.
> 
> > The AST2700 SoC defines two parent interrupt controller blocks
> > (INTC0 and INTC1), each containing multiple interrupt-controller child
> > instances ("*-intc-ic"). The existing irqchip driver
> > (irq-aspeed-intc.c) currently only registers a single compatible
> > string: "aspeed,ast2700-intc-ic"
> >
> > To support device trees that describe the INTC0 and INTC1 hierarchy
> > more precisely, this patch adds two additional
> 
> s/this patch adds/add/
will fix.
> 
> git grep 'This patch' Documentation/process/
> 
will fix.

> > compatible strings:
> >  - "aspeed,ast2700-intc0-ic"
> >  - "aspeed,ast2700-intc1-ic"
> >
> > Both map to the same initialization function
> > `aspeed_intc_ic_of_init()`.
> 
> The backticks are pointless. Just write aspeed...init()

will fix.

Thanks a lot.
> 
> Thanks,
> 
>         tglx