linux-kernel - Re: [PATCH v6 0/8] RTL8231 GPIO expander support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69a020e444bfbd3b72971dec3a34261ff8d39f24.camel@svanheule.net>
Date: Thu, 23 Oct 2025 11:09:57 +0200
From: Sander Vanheule <sander@...nheule.net>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Michael Walle <mwalle@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, 	linux-gpio@...r.kernel.org, Lee Jones
 <lee@...nel.org>, Pavel Machek	 <pavel@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski	 <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, 	linux-leds@...r.kernel.org,
 devicetree@...r.kernel.org, 	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/8] RTL8231 GPIO expander support

Hi,

On Thu, 2025-10-23 at 11:05 +0200, Bartosz Golaszewski wrote:
> On Tue, Oct 21, 2025 at 4:24 PM Sander Vanheule <sander@...nheule.net> wrote:
> > 
> > The RTL8231 GPIO and LED expander can be configured for use as an MDIO
> > or SMI bus device. Currently only the MDIO mode is supported, although
> > SMI mode support should be fairly straightforward, once an SMI bus
> > driver is available.
> > 
> > Provided features by the RTL8231:
> >   - Up to 37 GPIOs
> >     - Configurable drive strength: 8mA or 4mA (currently unsupported)
> >     - Input debouncing on GPIOs 31-36
> >   - Up to 88 LEDs in multiple scan matrix groups
> >     - On, off, or one of six toggling intervals
> >     - "single-color mode": 2×36 single color LEDs + 8 bi-color LEDs
> >     - "bi-color mode": (12 + 2×6) bi-color LEDs + 24 single color LEDs
> >   - Up to one PWM output (currently unsupported)
> >     - Fixed duty cycle, 8 selectable frequencies (1.2kHz - 4.8kHz)
> > 
> > The patches have been in use downstream by OpenWrt for some months. As
> > the original patches are already a few years old, I would like to request
> > all patches to be reviewed again (and I've dropped all provided tags and
> > changelogs).
> > ---
> > RFC for gpio-regmap changes:
> > Link:
> > https://lore.kernel.org/lkml/20251020115636.55417-1-sander@svanheule.net/
> > 
> > Patch series v5 (June 2021):
> > Link:
> > https://lore.kernel.org/lkml/cover.1623532208.git.sander@svanheule.net/
> > 
> > Sander Vanheule (8):
> >   gpio: regmap: Force writes for aliased data regs
> >   gpio: regmap: Bypass cache for aliased inputs
> 
> If I'm not mistaken, nothing depends on these two at build-time, so I
> can just take them through the GPIO tree for v6.19?

That's okay for me.

Best,
Sander