linux-kernel - Re: [PATCH] printk_legacy_map: use LD_WAIT_CONFIG instead of LD_WAIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251023092812.GA26461@redhat.com>
Date: Thu, 23 Oct 2025 11:28:13 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: Petr Mladek <pmladek@...e.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	John Ogness <john.ogness@...utronix.de>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk_legacy_map: use LD_WAIT_CONFIG instead of
 LD_WAIT_SLEEP

On 10/23, Petr Mladek wrote:
>
> Reviewed-by: Petr Mladek <pmladek@...e.com>

Thanks!

> This is much more clear. It might make sense to improve the comment,
> for example:
>
> <proposal>
> /*
>  * Legacy console printing from printk() caller context does not respect
>  * raw_spinlock/spinlock nesting. However, on PREEMPT_RT the printing
>  * path from atomic context is always avoided and the console driver
>  * is always invoked from a dedicated thread. Thus the lockdep splat
>  * on !PREEMPT_RT is a false positive.
>  *
>  * This map is used to temporarily establish LD_WAIT_CONFIG context for the
>  * console write() callback when legacy printing to avoid false positive
>  * lockdep complaints, thus allowing lockdep to continue to function for
>  * real issues.
>  */
> </proposal>

Agreed, will do and send V2.

Oleg.