linux-kernel - Re: [PATCH] i2c: pcf8584: Make pcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6pkzvfpzkg6mriqs7flbs5a2534tc6pk4ujs77h625xwlly5hu@fxxotb4oeh7q>
Date: Thu, 23 Oct 2025 12:53:30 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Cezar Chiru <chiru.cezar.89@...il.com>
Cc: wsa+renesas@...g-engineering.com, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: pcf8584: Make pcf_doAddress() function void

Hi Cezar,

thanks for taking care of this.

On Wed, Oct 22, 2025 at 04:54:05AM +0300, Cezar Chiru wrote:
> Change pcf_doAddress() function's type from int to void as it is always

The "is" is not needed.

> returns 0. This way there is no need for extra assignment and extra checks
> when the function is called.
> Remove assignment of pcf_doAddress() and replace it with a simple function
> call.
> 
> Signed-off-by: Cezar Chiru <chiru.cezar.89@...il.com>

It's not that I care much myself, but normally when someone
suggests a change, you should recognize it with "Suggested-by".

Please insert this patch in the same series with your

"[PATCH v8 1/1] i2c: pcf8584: Move 'ret' ... "

patch.

> ---
>  drivers/i2c/algos/i2c-algo-pcf.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-pcf.c
> index d1b0e55fd871..7e4a6d19494b 100644
> --- a/drivers/i2c/algos/i2c-algo-pcf.c
> +++ b/drivers/i2c/algos/i2c-algo-pcf.c
> @@ -253,7 +253,7 @@ static int pcf_readbytes(struct i2c_adapter *i2c_adap, char *buf,
>  }
>  
>  
> -static int pcf_doAddress(struct i2c_algo_pcf_data *adap,
> +static void pcf_doAddress(struct i2c_algo_pcf_data *adap,

while you are at this you can use the chance to rename this
function to a more kernel style naming. E.g.:

	pcf_send_address()

I would accept it in the same patch, but if you prefer you can
send it as a 3/3 patch. Your choice.

In any case, thanks for these cleanups!

Andi

>  			 struct i2c_msg *msg)
>  {