linux-kernel - Re: [PATCH] net: alteon: migrate to dma_map_phys instead of map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1fb1a9dc-e4c0-40a0-9536-82653b5d0598@redhat.com>
Date: Thu, 23 Oct 2025 13:03:30 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Chu Guangqing <chuguangqing@...pur.com>, jes@...ined-monkey.org,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.xn--org-o16s
Cc: linux-acenic@...site.dk, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: alteon: migrate to dma_map_phys instead of map_page

On 10/21/25 4:09 AM, Chu Guangqing wrote:
> @@ -2362,9 +2359,8 @@ ace_map_tx_skb(struct ace_private *ap, struct sk_buff *skb,
>  	dma_addr_t mapping;
>  	struct tx_ring_info *info;
>  
> -	mapping = dma_map_page(&ap->pdev->dev, virt_to_page(skb->data),
> -			       offset_in_page(skb->data), skb->len,
> -			       DMA_TO_DEVICE);
> +	mapping = dma_map_phys(&ap->pdev->dev, skb->data,
> +			       skb->len, DMA_TO_DEVICE, 0);

It looks like here a virt_to_phys() is missing around skb->data.

/P