linux-kernel - Re: [PATCH v1 1/1] s390/pci: Restore IRQ unconditionally for the zPCI device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3c612a9c5c9588508ca396baee2131699467bf8.camel@linux.ibm.com>
Date: Thu, 23 Oct 2025 14:09:22 +0200
From: Niklas Schnelle <schnelle@...ux.ibm.com>
To: Heiko Carstens <hca@...ux.ibm.com>
Cc: Farhan Ali <alifm@...ux.ibm.com>, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, mjrosato@...ux.ibm.com,
        agordeev@...ux.ibm.com, gor@...ux.ibm.com
Subject: Re: [PATCH v1 1/1] s390/pci: Restore IRQ unconditionally for the
 zPCI device

On Thu, 2025-10-23 at 14:00 +0200, Heiko Carstens wrote:
> On Thu, Oct 23, 2025 at 01:18:54PM +0200, Niklas Schnelle wrote:
> > On Thu, 2025-10-23 at 09:40 +0200, Heiko Carstens wrote:
> > > On Wed, Oct 22, 2025 at 09:47:26AM -0700, Farhan Ali wrote:
> > > > Commit c1e18c17bda6 ("s390/pci: add zpci_set_irq()/zpci_clear_irq()"),
> > > > introduced the zpci_set_irq() and zpci_clear_irq(), to be used while
> > > > resetting a zPCI device.
> ...
> > > The above sounds like this fixes a regression. Is there a reason why
> > > there are no Fixes and stable tags?
> > 
> > It doesn't have a fixes tag because at the moment the problem is
> > theoretical because no driver uses plain pci_restore_state() in
> > recovery. Farhan is working on patches where this would be used in
> > vfio-pci / PCI pass-through scenarios though.
> > 
> > The existing drivers re-use their shutdown and initialization routines
> > to restore state and end up calling arch_teardown_msi_irqs() and
> > arch_setup_msi_irqs() so it works out ok there. 
> > 
> > That said, I agree this could and probably should carry a fixes tag
> > since the logic is kind of broken even if it doesn't break anything at
> > the moment.
> 
> Can then somebody :) provide a tag, please? I'll add it when applying;
> no need for a new version.

Of course :)

Cc: stable@...r.kernnel.org
Fixes: c1e18c17bda6 ("s390/pci: add zpci_set_irq()/zpci_clear_irq()")