[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1877f731-1599-414d-a40e-38aec05a33c0@kernel.org>
Date: Thu, 23 Oct 2025 15:21:40 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Clément Le Goffic <legoffic.clement@...il.com>,
Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Julius Werner <jwerner@...omium.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org,
Clément Le Goffic <clement.legoffic@...s.st.com>
Subject: Re: [PATCH v8 2/7] dt-bindings: memory: introduce DDR4
On 30/09/2025 10:46, Clément Le Goffic wrote:
> From: Clément Le Goffic <clement.legoffic@...s.st.com>
>
> Introduce JEDEC compliant DDR bindings, that use new memory-props binding.
If there is going to be resend, then please repeat here applicable part
of compatible format, e.g. why it's like that.
>
> Signed-off-by: Clément Le Goffic <clement.legoffic@...s.st.com>
> Signed-off-by: Clément Le Goffic <legoffic.clement@...il.com>
> ---
> .../memory-controllers/ddr/jedec,ddr4.yaml | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,ddr4.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,ddr4.yaml
> new file mode 100644
> index 000000000000..a2eb6f63c0ce
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,ddr4.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/ddr/jedec,ddr4.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: DDR4 SDRAM compliant to JEDEC JESD79-4D
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@...nel.org>
> +
> +allOf:
> + - $ref: jedec,sdram-props.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - pattern: "^ddr4-[0-9a-f]{4},[a-z]{1,20},[0-9a-f]{2}$"
Why double ','? I would imagine last ',' to be '-':
ddrX-YYYY,AAAA...-ZZ
Sorry if we discuss that already, but then please remind me and this
would need addressing in commit msg.
> + - const: jedec,ddr4
Best regards,
Krzysztof
Powered by blists - more mailing lists