linux-kernel - Re: [PATCH] ASoC: spacemit: add failure check for spacemit_i2s_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5446E6EB4FCF412B+aPuLCQcV8hMlBLjk@troy-wujie14pro-arch>
Date: Fri, 24 Oct 2025 22:19:53 +0800
From: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
	Troy Mitchell <troy.mitchell@...ux.spacemit.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Yixun Lan <dlan@...too.org>, linux-sound@...r.kernel.org,
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: spacemit: add failure check for
 spacemit_i2s_init_dai()

On Fri, Oct 24, 2025 at 05:13:48PM +0300, Dan Carpenter wrote:
> On Fri, Oct 24, 2025 at 09:11:01PM +0800, Troy Mitchell wrote:
> > Add error handling when memory allocation for dai fails in
> > spacemit_i2s_init_dai() call.
> > 
> > Signed-off-by: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
> > Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---
> > Dan reported here [1].
> > 
> > Link: https://lore.kernel.org/all/aPtiNCZ_KBezL2Dr@stanley.mountain/#t [1]
> 
> Thanks, Troy
> 
> Normally we would say this needs a Fixes tag and the Link: should be a
> Closes: tag.  It would be easy to make the argument that the
> allocation won't fail in real life so a Fixes tag isn't appropriate.  But
> actually it's simpler to add the tag...
I see. Thanks!

Should I send v2 with Fixes tag now,
or would it be better to wait a bit?

                - Troy