linux-kernel - fs/9p/vfs_dentry.c:112 __v9fs_lookup_revalidate() warn: inconsistent indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202510242207.kbIt1Wet-lkp@intel.com>
Date: Fri, 24 Oct 2025 22:40:11 +0800
From: kernel test robot <lkp@...el.com>
To: Dominique Martinet <asmadeus@...ewreck.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: fs/9p/vfs_dentry.c:112 __v9fs_lookup_revalidate() warn: inconsistent
 indenting

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   6fab32bb6508abbb8b7b1c5498e44f0c32320ed5
commit: 43c36a56ccf6d9b07b4b3f4f614756e687dcdc01 Revert "fs/9p: Refresh metadata in d_revalidate for uncached mode too"
date:   2 days ago
config: x86_64-randconfig-161-20251024 (https://download.01.org/0day-ci/archive/20251024/202510242207.kbIt1Wet-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510242207.kbIt1Wet-lkp@intel.com/

smatch warnings:
fs/9p/vfs_dentry.c:112 __v9fs_lookup_revalidate() warn: inconsistent indenting

vim +112 fs/9p/vfs_dentry.c

    63	
    64	static int __v9fs_lookup_revalidate(struct dentry *dentry, unsigned int flags)
    65	{
    66		struct p9_fid *fid;
    67		struct inode *inode;
    68		struct v9fs_inode *v9inode;
    69	
    70		if (flags & LOOKUP_RCU)
    71			return -ECHILD;
    72	
    73		inode = d_inode(dentry);
    74		if (!inode)
    75			goto out_valid;
    76	
    77		v9inode = V9FS_I(inode);
    78		if (v9inode->cache_validity & V9FS_INO_INVALID_ATTR) {
    79			int retval;
    80			struct v9fs_session_info *v9ses;
    81	
    82			fid = v9fs_fid_lookup(dentry);
    83			if (IS_ERR(fid)) {
    84				p9_debug(
    85					P9_DEBUG_VFS,
    86					"v9fs_fid_lookup: dentry = %pd (%p), got error %pe\n",
    87					dentry, dentry, fid);
    88				return PTR_ERR(fid);
    89			}
    90	
    91			v9ses = v9fs_inode2v9ses(inode);
    92			if (v9fs_proto_dotl(v9ses))
    93				retval = v9fs_refresh_inode_dotl(fid, inode);
    94			else
    95				retval = v9fs_refresh_inode(fid, inode);
    96			p9_fid_put(fid);
    97	
    98			if (retval == -ENOENT) {
    99				p9_debug(P9_DEBUG_VFS, "dentry: %pd (%p) invalidated due to ENOENT\n",
   100					 dentry, dentry);
   101				return 0;
   102			}
   103			if (v9inode->cache_validity & V9FS_INO_INVALID_ATTR) {
   104				p9_debug(P9_DEBUG_VFS, "dentry: %pd (%p) invalidated due to type change\n",
   105					 dentry, dentry);
   106				return 0;
   107			}
   108			if (retval < 0) {
   109				p9_debug(P9_DEBUG_VFS,
   110					"refresh inode: dentry = %pd (%p), got error %pe\n",
   111					dentry, dentry, ERR_PTR(retval));
 > 112			if (retval < 0)
   113				return retval;
   114			}
   115		}
   116	out_valid:
   117		p9_debug(P9_DEBUG_VFS, "dentry: %pd (%p) is valid\n", dentry, dentry);
   118		return 1;
   119	}
   120	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki