linux-kernel - Re: [PATCH net v3 1/3] net: stmmac: vlan: Disable 802.1AD tag insertion offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12fa7c65-c257-4013-baf9-695ff4c2a4bd@altera.com>
Date: Fri, 24 Oct 2025 08:33:20 +0530
From: "G Thomas, Rohan" <rohan.g.thomas@...era.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <Jose.Abreu@...opsys.com>,
 Rohan G Thomas <rohan.g.thomas@...el.com>,
 "Ng, Boon Khai" <boon.khai.ng@...era.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-stm32@...md-mailman.stormreply.com"
 <linux-stm32@...md-mailman.stormreply.com>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v3 1/3] net: stmmac: vlan: Disable 802.1AD tag
 insertion offload

Hi Russell,

On 10/23/2025 4:24 PM, Russell King (Oracle) wrote:
> On Thu, Oct 23, 2025 at 09:01:20AM +0530, G Thomas, Rohan wrote:
>> Hi Russell,
>>
>> On 10/18/2025 7:26 AM, G Thomas, Rohan wrote:
>>> Hi Russell,
>>>
>>> On 10/17/2025 6:12 PM, Russell King (Oracle) wrote:
>>>> On Fri, Oct 17, 2025 at 02:11:19PM +0800, Rohan G Thomas via B4 Relay wrote:
>>>>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>>>>> index 650d75b73e0b0ecd02d35dd5d6a8742d45188c47..dedaaef3208bfadc105961029f79d0d26c3289d8 100644
>>>>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>>>>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>>>>> @@ -4089,18 +4089,11 @@ static int stmmac_release(struct net_device *dev)
>>>>>     static bool stmmac_vlan_insert(struct stmmac_priv *priv, struct sk_buff *skb,
>>>>>     			       struct stmmac_tx_queue *tx_q)
>>>>>     {
>>>>> -	u16 tag = 0x0, inner_tag = 0x0;
>>>>> -	u32 inner_type = 0x0;
>>>>> +	u16 tag = 0x0;
>>>>>     	struct dma_desc *p;
>>>>
>>>> #include <stdnetdevcodeformat.h> - Please maintain reverse christmas-
>>>> tree order.
>>>
>>> Thanks for pointing this out. I'll fix the declaration order in the next
>>> revision.
>>>
>>>>
>>>> I haven't yet referred to the databook, so there may be more comments
>>>> coming next week.
>>>>
>>>
>>> Sure! Will wait for your feedback before sending the next revision.
>>
>> Just checking in — have you had a chance to review the patch further? Or
>> would it be okay for me to go ahead and send the next revision for
>> review?
> 
> I've checked my version of the databook, and the core version that has
> VLINS/DVLAN and my databook doesn't cover this. So I'm afraid I can't
> review further.
> 

Thanks for checking. Understood.

Following public document appears to include the DWMAC QoS IP databook.
Section 44 of the following user manual might be a useful reference.
https://www.infineon.com/row/public/documents/10/44/infineon-aurix-tc3xx-part2-usermanual-en.pdf

Best Regards,
Rohan