linux-kernel - Re: Re: [PATCH] RISC-V: KVM: Remove automatic I/O mapping for VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhSdy1+TLUgi54uiHg7xomUo7tA_rs7Kt6b4OdUCvDQXjZYiQ@mail.gmail.com>
Date: Fri, 24 Oct 2025 21:27:06 +0530
From: Anup Patel <anup@...infault.org>
To: fangyu.yu@...ux.alibaba.com
Cc: alex@...ti.fr, aou@...s.berkeley.edu, atish.patra@...ux.dev, 
	guoren@...nel.org, jiangyifei@...wei.com, kvm-riscv@...ts.infradead.org, 
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, palmer@...belt.com, pbonzini@...hat.com, 
	pjw@...nel.org
Subject: Re: Re: [PATCH] RISC-V: KVM: Remove automatic I/O mapping for VM_PFNMAP

On Fri, Oct 24, 2025 at 8:55 PM Anup Patel <anup@...infault.org> wrote:
>
> On Fri, Oct 24, 2025 at 7:01 PM <fangyu.yu@...ux.alibaba.com> wrote:
> >
> > >> From: Fangyu Yu <fangyu.yu@...ux.alibaba.com>
> > >>
> > >> As of commit aac6db75a9fc ("vfio/pci: Use unmap_mapping_range()"),
> > >> vm_pgoff may no longer guaranteed to hold the PFN for VM_PFNMAP
> > >> regions. Using vma->vm_pgoff to derive the HPA here may therefore
> > >> produce incorrect mappings.
> > >>
> > >> Instead, I/O mappings for such regions can be established on-demand
> > >> during g-stage page faults, making the upfront ioremap in this path
> > >> is unnecessary.
> > >>
> > >> Fixes: 9d05c1fee837 ("RISC-V: KVM: Implement stage2 page table programming")
> > >> Signed-off-by: Fangyu Yu <fangyu.yu@...ux.alibaba.com>
> > >
> > >LGTM.
> > >
> > >Queued it as fix for Linux-6.18
> > >
> > >Reviewed-by: Anup Patel <anup@...infault.org>
> > >
> > >Thanks,
> > >Anup
> > >
> >
> > Hi Anup:
> >
> > Thanks for the review.
> >
> > Please note that this patch has two build warnings, and I have fixed
> > on patch V2:
> > https://lore.kernel.org/linux-riscv/20251021142131.78796-1-fangyu.yu@linux.alibaba.com/
> >
>
> Can you send a separate patch with Fixes tag to this patch?
>
> You can base the patch on riscv_kvm_next branch at:
> https://github.com/kvm-riscv/linux.git
>

For some reason, your v2 patch never showed up in my inbox :(

No need for a separate patch. I have picked your v2.

Regards,
Anup